This repository has been archived by the owner on Jan 31, 2018. It is now read-only.
Convert MobileQueryStringOverrideTest to an ElasticTestCase. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,12 +21,11 @@ def test_mobile_override(self): | |||
| # Doing a request and specifying the mobile querystring | |||
| # parameter should persist that value in the MOBILE cookie. | |||
| resp = self.client.get(reverse('home_view'), { | |||
| 'mobile': 1 | |||
| }) | |||
| 'mobile': 1 | |||
There was a problem hiding this comment.
Nit: This should be at two indentation levels. The first is the (, the second is the {. So it was correct initially.
There was a problem hiding this comment.
So, first, I never heard the rule explained like that, now things make a lot more sense.
Second, the reason I did this is because a new linter I had was complaining about it, but that linter is being more annoying than it is worth, so it is going away.
|
This works great! I had two nits, but r+. |
Since MobileQueryStringOverrideTest accesses the dashboard (since the dashboard is the front page), it needs to be using the correct elastic search index, so it needs to be a ElasticTestCase, instead of a normal TestCase.
|
Landed in 36ff739. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MobileQueryStringOverrideTest accesses the dashboard (since the dashboard is the front page), it needs to be using the correct elastic search index, so it needs to be a ElasticTestCase, instead of a normal TestCase.
The upshot of all this is that Jenkins will stop being angry for no good reason about this test.
r?