Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

1097847 admin views #383

Merged
merged 2 commits into from
Nov 18, 2014
Merged

1097847 admin views #383

merged 2 commits into from
Nov 18, 2014

Conversation

willkg
Copy link
Member

@willkg willkg commented Nov 18, 2014

Ugh.

r?

This is the version of django-grappelli that works with Django 1.6.
django-adminplus changed the register_view signature. This updates all
the places we use admin.site.register_view so it's correct and our
custom views show up in the admin.

django-grappelli 2.5.6 has a section for django-adminplus, but it's
bizarre and doesn't work right. This updates our grappellioverride to
make it less disfunctional.

Updated the comment in fjord/settings/base.py regarding the grappelli
override.
@willkg
Copy link
Member Author

willkg commented Nov 18, 2014

To test:

  1. run the server
  2. go into the admin
  3. do the custom views show up? yes? yay.

@willkg
Copy link
Member Author

willkg commented Nov 18, 2014

On second thought, there's nothing interesting here, so I'm just going to land it.

self-r+

willkg added a commit that referenced this pull request Nov 18, 2014
@willkg willkg merged commit 2c4b4d2 into mozilla:master Nov 18, 2014
@willkg
Copy link
Member Author

willkg commented Nov 18, 2014

4f3b9c7 [bug 1097847] Fix custom views in admin
73a4225 [bug 1097847] Update django-grappelli to 2.5.6

@rlr
Copy link
Contributor

rlr commented Nov 18, 2014

yep. just finished looking at it. r+

@willkg willkg deleted the 1097847-admin-views branch November 18, 2014 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants