Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Figure component #1902

Closed
alanmoo opened this issue Oct 5, 2018 · 3 comments
Closed

Remove deprecated Figure component #1902

alanmoo opened this issue Oct 5, 2018 · 3 comments
Assignees
@youriwims
Labels
backend code cleanup wagtail wagtail related issues
Projects
Foundation Site

Comments

@alanmoo
Copy link
Contributor

alanmoo commented Oct 5, 2018

This requires access to the production environment, but we should remove all instances of deprecated components using the Block Inventory feature to find them, and then remove those components from the codebase.
@Pomax Pomax added help wanted wagtail wagtail related issues backend labels Jan 29, 2019
@kristinashu kristinashu added this to Backlog in Foundation Site via automation Jan 29, 2019
@kristinashu kristinashu moved this from Backlog to Up Next in Foundation Site Feb 11, 2019
@kristinashu kristinashu mentioned this issue Feb 20, 2019
Closed
7 tasks
@kristinashu kristinashu self-assigned this Feb 22, 2019
@kristinashu
Copy link

I will go review https://foundation.mozilla.org/cms/inventory/ and make sure no deprecated components are in use.

cc @Pomax

@alanmoo
Copy link
Contributor Author

alanmoo commented Feb 22, 2019

Once you've confirmed, this is probably something @youriwims could take care of.

@youriwims youriwims mentioned this issue Feb 28, 2019
Closed
@kristinashu
Copy link

kristinashu commented Mar 4, 2019 •
edited by youriwims

These are the deprecated components and all instances of them have been removed on prod so they are ready to be removed.

image

@kristinashu kristinashu removed their assignment Mar 4, 2019
@Pomax Pomax mentioned this issue Mar 5, 2019
Merged
1 task
@youriwims youriwims self-assigned this Mar 11, 2019
@kristinashu kristinashu moved this from Up Next to In Progress in Foundation Site Mar 11, 2019
@kristinashu kristinashu changed the title Remove deprecated components Remove deprecated components (Figure) Mar 11, 2019
@youriwims youriwims changed the title Remove deprecated components (Figure) Remove deprecated Figure component Mar 12, 2019
@youriwims youriwims moved this from In Progress to Up Next in Foundation Site Mar 12, 2019
This was referenced Mar 15, 2019
Merged
Merged
@youriwims youriwims moved this from Up Next to In Progress in Foundation Site Mar 20, 2019
@youriwims youriwims moved this from In Progress to In Review in Foundation Site Mar 20, 2019
Foundation Site automation moved this from In Review to Done Mar 20, 2019
alanmoo pushed a commit that referenced this issue Mar 20, 2019
@alanmoo
[Deprecated Component Removal] Figure Block (#2858)
270415b 
Closes #1902 
All instances of this component have been removed on prod as per [this comment](#1902 (comment)), so removing it from models and custom blocks can be safely done on this pr.

## Checklist

**Changes in Models:**
- [x] Did I update or add new fake data?
@youriwims youriwims mentioned this issue Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youriwims youriwims

Labels
backend code cleanup wagtail wagtail related issues
Projects
No open projects
Foundation Site
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Pomax @kristinashu @alanmoo @youriwims