Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publications] Design QA #5682

Closed
kristinashu opened this issue Nov 20, 2020 · 3 comments
Closed

[Publications] Design QA #5682

kristinashu opened this issue Nov 20, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@kristinashu
Copy link

Once all the content has been entered in #5536. Design to do further QA, combine feedback with the (existing feedback), and open dev tickets for implementation.

@sabrinang
Copy link

sabrinang commented Dec 2, 2020

Things to revise:

  • Navigation: missing menu on viewports > 990px (should be similar to blog nav)

image

  • Publications heading subtitle: 20px/30px to be body-large size (currently 28px/36px)

  • Footnotes: feel a bit too large especially when there are a few (suggested 14px/20px)

  • Italics are in nunito light → nunito regular

  • previous/next buttons on child publications to link to next chapter instead of back to the same chapter to connect reading experience

Wide Image streamfield

  • could we have the height be the height of the image (possibility of having more narrow wide images as it stretches out narrow images and become pixelated)?

Feedback to consider:

  • should chapter/subchapter numbers be reflected on article pages?
  • could footnotes be more user friendly? (wasn't as intuitive for user to use without guidance)
  • numbered lists didn't copy and paste well (best to not copy/paste from pdf as it carries over some line breaks and omits some lists etc.)

These notes were taken from Jam and mine experience importing content: https://docs.google.com/document/d/1yM5DsKSeIUGktvx_x2G7S7EJe7pHDnEIkXMYtIMxj10/edit?usp=sharing

@sabrinang
Copy link

QA notes captured here and #5312 (comment).
Ready for review and can meet Kalob on Monday to open tickets.

@sabrinang
Copy link

Reviewed this #5682 (comment) and previous #5312 (comment) with @KalobTaulien over zoom and he'll open up tickets based on those and get them into sprint planning tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants