This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
Add exemption for lang param in locale middleware. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,9 @@ | |||
| from .helpers import urlparams | |||
|
|
|||
|
|
|||
| EXEMPT_URLS = getattr(settings, 'FF_EXEMPT_LANG_PARAM_URLS', None) | |||
There was a problem hiding this comment.
I would default this to an empty list instead of None here so you can always iterate through it.
There was a problem hiding this comment.
I also wonder if s/URL/PATH/g would make more sense here.
There was a problem hiding this comment.
There are just other settings that use URL. Figured it was more consistent.
|
If no one else has any objections I'm going to rebase and merge. |
There may be some URLs which have other uses for a 'lang' query parameter. This allows you to set such URLs as exempt.
|
r+ |
pmclanahan
pushed a commit
that referenced
this pull request
Sep 16, 2013
Add exemption for lang param in locale middleware.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be some URLs which have other uses for a
'lang' query parameter. This allows you to set such URLs as exempt.
This is mostly for bedrock, as we need the /firefox/download/ page
to accept a ?lang= parameter that refers to the language of the
Fx build you wish to download. That param for that page has existed
for a long time and we're trying to port it from the PHP side
to bedrock.