fix(email): update subscription TOS url to be correct #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbudhram
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
@johngruen LGTM, I think we could probably update/remove this one as well,
.
|
oh yeah, good catch...i'll do that and merge |
johngruen
force-pushed
the
update-subscription-terms-url-in-email
branch
from
2ee19a7
to
c474aa0
Compare
|
Just a note: This doesn't necessarily change the URL in any deployments (i.e. dev / prod / stage) - this PR just changes the local development setting and the config default. The actual URL is a server setting that we'll need to get ops help to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3301