refactor(api): prefer async/await in lib/routes/account.js #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
chenba
force-pushed
the
2305-async-await-account
branch
from
fcdac44
to
79f2b05
Compare
chenba
changed the title
lmorchard
approved these changes
Dec 17, 2019
| secondaryEmailRecord.email | ||
| ); | ||
| await customs.check(request, email, 'accountCreate'); | ||
| await deleteAccountIfUnverified(); |
There was a problem hiding this comment.
Kind of wish we'd un-wrap & inline all these functions along the way to await-ifying & simplifying things.
But, on the other hand, I guess this kind of serves as a table-of-contents for the functionality. Also makes the conversion safer and smaller.
So, I'm mainly thinking out loud and this is not even a nit.
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2305
@mozilla/fxa-devs r?