Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FxA 16 mockups added and description change #64

Merged
merged 1 commit into from
Oct 27, 2015

Conversation

ryanfeeley
Copy link
Contributor

Fixes #62

(edited by @rfk)

Since I think we should get multiple people's signoff on the details here, I'm adding some checkboxes:

Let's not land this until we have that three-way dev/ux/product agreement that this captures the experience we want to ship in this milestone.

@@ -4,5 +4,19 @@ Device View - Basic UI

https://mozilla.aha.io/features/FXA-16

As A FF user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, record counts of different data types, and optionally data storage size (perhaps an option for self-hosters or others?)
As a FF user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, and optionally data storage size (perhaps an option for self-hosters or others?)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed record counts because it seemed out of scope (all syncing devices will have the same number of records).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this can take more work that we think, we might need a milestone for that one.

@vladikoff vladikoff added this to the FxA-16: devices view milestone Oct 21, 2015

## Collapsed View
![Collapsed View](devices1-collapsed.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under "Devices" does it make sense to show how many I have or is that too much work?

Devices (3)

@billmaggs
Copy link

What happened to a link for the UA string in the Reviewing (Managing) view? I think we agreed this would be useful. Otherwise, looks good.

@@ -4,5 +4,19 @@ Device View - Basic UI

https://mozilla.aha.io/features/FXA-16

As A FF user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, record counts of different data types, and optionally data storage size (perhaps an option for self-hosters or others?)
As a Firefox Accounts user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, and optionally data storage size (perhaps an option for self-hosters or others?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "about my the status"

I also think we could remove any mention of "services" from this description because it's really not obvious what that means.

@shane-tomlinson
Copy link
Contributor

@ryanfeeley:

  • What does Refresh do, just refresh the list? Like @vladikoff, I'm not fully convinced of its value.
  • If a user clicks Review next to a device, what is the transition to the Reviewing View? If there are 2 or more devices, Is the entire original panel replaced? Would that look jerky?
  • From the Reviewing View to Rename View, what is the transition? Is the panel replaced?
  • If yes to panel replacements, it seems like that could be very jerky. Would a modal, like the Avatar update uses, work better here?
  • In the Reviewing View, do we have to limit the device name length? How will this look on mobile UIs?
  • In Devices, are there icons for TVs and tablets too?
  • What happens if a user disconnects a device, is it removed from the list or marked as inactive? Can the user re-connect that device?
  • What happens if the user disconnects the current device? Does that sign them out of FxA, or just disconnect their Sync session? Can the user re-sign in to Sync from this panel?
  • What happens if the user signed up to Pocket but not Sync, is their device shown in the list? Can the user sign in to Sync from this panel?
  • It seems like there is a tension in the design and including "Devices" within FxA - FxA is a general authentication system, but Devices in its current incarnation seems pretty Sync specific. Is the Device list supposed to show all devices where the user has signed in to FxA or just those used to sign in to Sync? If so, should the "Devices" title be "Devices connected to Sync", "Syncing devices" or similar?
    • Would this functionality be better placed into the browser's about:preferences#sync pane? (I can think of reasons not to, namely remotely revoking the session of a stolen device w/o requiring signing in to the browser)

If push comes to shove and time is tight, can building the UI be phased? One possibility:

Phase 1

  • In Expanded View, replace the Review buttons with Disconnect buttons.

Phase 2

  • Introduce device renaming.

@shane-tomlinson
Copy link
Contributor

As a Firefox Accounts user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account

Is a Services view forthcoming? If so, will they be services per device?

@rfk
Copy link
Contributor

rfk commented Oct 22, 2015

Is a Services view forthcoming? If so, will they be services per device?

I don't think we yet understand enough about what "services" means to the user in the context of FxA, and we should:

  • remove any mention of it from this feature
  • not try to forward-design affordances for it in this feature, because YAGNI

@billmaggs what do you think?

@rfk
Copy link
Contributor

rfk commented Oct 22, 2015

It occurs to me that github may not notify of edits to existing comments, so: I edited the description to contain two review checkboxes so we can keep track of the state of all stakeholders here

@billmaggs
Copy link

I totally support taking out Services until we have a good reason for it.

We should change Review to Manage -- @ryanfeeley, this is cool by you? Neither is great but Review is too weird.

Disconnecting a remote device - seems like we could either grey it out or remove it, but clearly once its done, its done.

Disconnecting your current device....this has to sign you out of Sync, no? And take you to the Logged out Sync pref page?

I'm agnostic on the Refresh experience--it does make the user feel more actively in control.

@rfk
Copy link
Contributor

rfk commented Oct 22, 2015

What happens if a user disconnects a device, is it removed from the list or marked as inactive?
Can the user re-connect that device?

We have two states available on the backend: we can zap the sessionToken but keep the device record, or we can delete the entire device record. The first makes it possible for the user to go to that device and sign back in and have it appear to be the same device. The second makes it disappear entirely and if it comes back, will appear to be a new device.

I would lean slightly towards just deleting it entirely, and reserving the "inactive" state for e.g. devices that have to recover from a password reset of similar.

Disconnecting your current device....this has to sign you out of Sync, no?

Indeed it must, and it should probably redirect you somewhere because you'll lose your ability to interact with the page since you sessionToken will be invalided.

And take you to the Logged out Sync pref page?

I don't know how technically feasible it is to redirect into preferences, perhaps an acceptable short-term alternative would be to go to the webchannel-enabled sync signin page on the web? (the one used in the iframe for the first-run flow experience).

@ryanfeeley
Copy link
Contributor Author

I put the Refresh button there not only because one wide-ass Done button would look odd, but also because I assume that the list is not up-to-the-second up-to-date. So for example, if I am watching the list and on a different screen disconnect my phone, will the list be up-to-the-second up-to-date? If it will be, I'll go with a wide-ass Done button.

@ryanfeeley
Copy link
Contributor Author

Updated with minimal (no rename) view.

@rfk
Copy link
Contributor

rfk commented Oct 23, 2015

will the list be up-to-the-second up-to-date?

No, I don't think we should try for that in this initial version. Maybe one day when push is everywhere and available to web content.

@rfk
Copy link
Contributor

rfk commented Oct 23, 2015

What happened to a link for the UA string in the Reviewing

ref #62 (comment) where this was initially suggested.

Do you mean the full literal value from the user-agent header provided by the device? We have in general been discouraged from storing this information on the server because it's often uniquely identifying. The current backend stores only the broad browser/platform information extracted from the user-agent string.

If we want to show the full string, I think we'll have to loop in legal for approval. (@dannycoates pointed out that the "it's unqiuely identifying!" argument is mostly moot in this specific case, because it's stored right next to a plaintext email address, but it still tends to make our PII data guardians nervous).

@rfk
Copy link
Contributor

rfk commented Oct 23, 2015

In the Reviewing View, do we have to limit the device name length? How will this look on mobile UIs?

At the very least, the backend will restrict the length of names you can write to the server.

@rfk
Copy link
Contributor

rfk commented Oct 23, 2015

FYI, I tried to concretely capture some of the non-mocks-related discussion as a separate PR: #66

![Collapsed View](devices1-collapsed.png)

## Minimal View (no rename)
![Collapsed View](devices6-disconnect-and-refresh-only.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanfeeley I noticed this simple design (devices6-disconnect-and-refresh-only.png) is missing the browser type / version

Should we include it somehow?

This is the information we have access to:

+                device.uaBrowser = session.uaBrowser
+                device.uaBrowserVersion = session.uaBrowserVersion
+                device.uaOS = session.uaOS
+                device.uaOSVersion = session.uaOSVersion
+                device.uaDeviceType = session.uaDeviceType

@vladikoff
Copy link
Contributor

Talking to @ryanfeeley, this is now ready for final review. Shane once reviewed we should should squash the commits

@vladikoff vladikoff removed the WIP label Oct 27, 2015
shane-tomlinson pushed a commit that referenced this pull request Oct 27, 2015
@shane-tomlinson shane-tomlinson merged commit b91579a into master Oct 27, 2015
@rfk
Copy link
Contributor

rfk commented Oct 27, 2015

\o/

shane-tomlinson pushed a commit that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants