-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FxA 16 mockups added and description change #64
Conversation
@@ -4,5 +4,19 @@ Device View - Basic UI | |||
|
|||
https://mozilla.aha.io/features/FXA-16 | |||
|
|||
As A FF user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, record counts of different data types, and optionally data storage size (perhaps an option for self-hosters or others?) | |||
As a FF user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, and optionally data storage size (perhaps an option for self-hosters or others?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed record counts because it seemed out of scope (all syncing devices will have the same number of records).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this can take more work that we think, we might need a milestone for that one.
|
||
## Collapsed View | ||
![Collapsed View](devices1-collapsed.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under "Devices" does it make sense to show how many I have or is that too much work?
Devices (3)
What happened to a link for the UA string in the Reviewing (Managing) view? I think we agreed this would be useful. Otherwise, looks good. |
@@ -4,5 +4,19 @@ Device View - Basic UI | |||
|
|||
https://mozilla.aha.io/features/FXA-16 | |||
|
|||
As A FF user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, record counts of different data types, and optionally data storage size (perhaps an option for self-hosters or others?) | |||
As a Firefox Accounts user when using Firefox, I want to know the devices and services I am connected to via my Firefox Account, and important information about my the status of my services. For devices, this includes last time synced, and optionally data storage size (perhaps an option for self-hosters or others?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "about my the status"
I also think we could remove any mention of "services" from this description because it's really not obvious what that means.
If push comes to shove and time is tight, can building the UI be phased? One possibility: Phase 1
Phase 2
|
Is a Services view forthcoming? If so, will they be services per device? |
I don't think we yet understand enough about what "services" means to the user in the context of FxA, and we should:
@billmaggs what do you think? |
It occurs to me that github may not notify of edits to existing comments, so: I edited the description to contain two review checkboxes so we can keep track of the state of all stakeholders here |
I totally support taking out Services until we have a good reason for it. We should change Review to Manage -- @ryanfeeley, this is cool by you? Neither is great but Review is too weird. Disconnecting a remote device - seems like we could either grey it out or remove it, but clearly once its done, its done. Disconnecting your current device....this has to sign you out of Sync, no? And take you to the Logged out Sync pref page? I'm agnostic on the Refresh experience--it does make the user feel more actively in control. |
We have two states available on the backend: we can zap the sessionToken but keep the device record, or we can delete the entire device record. The first makes it possible for the user to go to that device and sign back in and have it appear to be the same device. The second makes it disappear entirely and if it comes back, will appear to be a new device. I would lean slightly towards just deleting it entirely, and reserving the "inactive" state for e.g. devices that have to recover from a password reset of similar.
Indeed it must, and it should probably redirect you somewhere because you'll lose your ability to interact with the page since you sessionToken will be invalided.
I don't know how technically feasible it is to redirect into preferences, perhaps an acceptable short-term alternative would be to go to the webchannel-enabled sync signin page on the web? (the one used in the iframe for the first-run flow experience). |
I put the Refresh button there not only because one wide-ass Done button would look odd, but also because I assume that the list is not up-to-the-second up-to-date. So for example, if I am watching the list and on a different screen disconnect my phone, will the list be up-to-the-second up-to-date? If it will be, I'll go with a wide-ass Done button. |
Updated with minimal (no rename) view. |
No, I don't think we should try for that in this initial version. Maybe one day when push is everywhere and available to web content. |
ref #62 (comment) where this was initially suggested. Do you mean the full literal value from the user-agent header provided by the device? We have in general been discouraged from storing this information on the server because it's often uniquely identifying. The current backend stores only the broad browser/platform information extracted from the user-agent string. If we want to show the full string, I think we'll have to loop in legal for approval. (@dannycoates pointed out that the "it's unqiuely identifying!" argument is mostly moot in this specific case, because it's stored right next to a plaintext email address, but it still tends to make our PII data guardians nervous). |
At the very least, the backend will restrict the length of names you can write to the server. |
FYI, I tried to concretely capture some of the non-mocks-related discussion as a separate PR: #66 |
![Collapsed View](devices1-collapsed.png) | ||
|
||
## Minimal View (no rename) | ||
![Collapsed View](devices6-disconnect-and-refresh-only.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanfeeley I noticed this simple design (devices6-disconnect-and-refresh-only.png) is missing the browser type / version
Should we include it somehow?
This is the information we have access to:
+ device.uaBrowser = session.uaBrowser
+ device.uaBrowserVersion = session.uaBrowserVersion
+ device.uaOS = session.uaOS
+ device.uaOSVersion = session.uaOSVersion
+ device.uaDeviceType = session.uaDeviceType
Talking to @ryanfeeley, this is now ready for final review. Shane once reviewed we should should squash the commits
|
794c142
to
fbf7474
Compare
FxA 16 mockups added and description change r=@shane-tomlinson, @billmaggs.
\o/ |
Fixes #62
(edited by @rfk)
Since I think we should get multiple people's signoff on the details here, I'm adding some checkboxes:
Let's not land this until we have that three-way dev/ux/product agreement that this captures the experience we want to ship in this milestone.