Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time-unit awareness to timespan metrics #2641

Open
edugfilho opened this issue Dec 19, 2023 · 1 comment
Open

Add time-unit awareness to timespan metrics #2641

edugfilho opened this issue Dec 19, 2023 · 1 comment

Comments

@edugfilho
Copy link
Collaborator

edugfilho commented Dec 19, 2023

Following 1630966 GLAM needs to be aware of the time-unit of a timespan type metric (Glean).
This will allow the timespans to change their time-unit (from milliseconds to seconds, for example) without causing aggregation problems.
Here's how I see this being implemented in the ETL and application without having to add new columns:'

  • Talk with the Glean team to gather the finest time-unit (microseconds, for example) that a metric can assume.
  • During the ETL, transform all timespan values to that time-unit and aggregate them.
  • Once in the app, fetch the timespan metric current time-unit and transform the values to it.

This work will likely require data to be migrated

@badboy
Copy link
Member

badboy commented Dec 20, 2023

I guess the probeinfo history for a metric has the time_unit for every history entry, so one could pick the first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants