Update radio types for GSM (#304) #338
Conversation
|
|
||
|
|
||
| def upgrade(): | ||
| stmt = 'UPDATE cell SET `radio` = 2 WHERE `radio` = 0 AND cid >= 65536;' |
There was a problem hiding this comment.
This is a bit too simple. It misses the duplicate detection. We have a whole bunch of cell entries where we have entries for the same mcc,mnc,lac,cid combination with both radio = gsm and radio = umts.
|
Looks good so far. But it still misses the duplication detection part. I wanted to know how many cell entries are duplicated across gsm/umts radio types or stated differently: how many conflicts do we get when trying to adjust the radio type for the existing data. Depending on how many conflicts we have, we can either drop the "bad" gsm results for cases where we already have a proper umts entry, or if it's too many we might want to merge the two cell entries into one. |
|
@hannosch I updated the migration. These three queries should handle each case properly I think. I tested locally and it seemed okay. |
|
f+, as mentioned on IRC one little detail is missing in the migration: Making sure there's an area entry (cid=-2) for every radio,mcc,mnc,lac combination, as switching the radio type on some cells might make those the first entry in an area. |
jaredlockhart
force-pushed
the
304
branch
3 times, most recently
from
d80dee0
to
d78784a
Compare
- Update cell processing to catch incorrect radio types - Add test - Add data migration
@hannosch