Ctrl-C doesn't terminate the Firefox process spawned by jpm run

[XrXr]

When using cfx run, using Ctrl-C in the terminal would end both cfx and the Firefox process it spawned.
Using Ctrl-C when jpm is in progress only ends jpm, not it's associated Firefox process.

[XrXr]

I'm still having the same issue on Windows with master at 88c37fe

[jsantell]

Hmm, wonder why this is.. I'll give this a go on a windows VM

[XrXr]

I get this error when I Ctrl-C

fs.js:760
  return binding.unlink(pathModule._makeLong(path));
                 ^
Error: EBUSY, resource busy or locked '...\4b576ccc-12f3-45c4-b2e0-8c09db2818e4\cert8.db'
    at Object.fs.unlinkSync (fs.js:760:18)
    at Object.exports.rmdirSyncRecursive (...\npm\node_modules\jpm\node_modules\firefox-profile\node_modules\wrench\lib\wrench.js:164:16)
    at FirefoxProfile.deleteDir (...\npm\node_modules\jpm\node_modules\firefox-profile\lib\firefox_profile.js:137:44)
    at process.FirefoxProfile.onExit (...\npm\node_modules\jpm\node_modules\firefox-profile\lib\firefox_profile.js:117:12)
    at process.EventEmitter.emit (events.js:92:17)
    at Signal.wrap.onsignal (node.js:757:46)

Firefox doesn't quit.

[jsantell]

Opened bug on firefox-profile-js

[saadtazi]

Hi @XrXr
can you please try it with firefox-profile@0.2.11?

[XrXr]

@saadtazi I now get this error

 console.warn('[firefox-profile] cannot delete profileDir on exit', profileDir
                                                                    ^
ReferenceError: profileDir is not defined
    at FirefoxProfile._cleanOnExit (...\npm\node_modules\jpm\node_modules\firefox-profile\lib\firefox_profile.js:200:74)
    at process.FirefoxProfile.onExit (...\npm\node_modules\jpm\node_modules\firefox-profile\lib\firefox_profile.js:119:12)
    at process.EventEmitter.emit (events.js:92:17)
    at Signal.wrap.onsignal (node.js:757:46)

[saadtazi]

my bad. I run the test but it is not yet covered by the tests... Please try with 0.2.12.

[XrXr]

@saadtazi Now I get

[firefox-profile] cannot delete profileDir on exit ...\AppData\Local\Temp\eac5238f-7f3c-4d13-ba57-ef023d65c952 { [Error: EBUSY, resource busy or locked '...\AppData\Local\Temp\eac5238f-7f3c-4d13-ba57-ef023d65c952\cert8.db']
  errno: 10,
  code: 'EBUSY',
  path: '...\\AppData\\Local\\Temp\\eac5238f-7f3c-4d13-ba57-ef023d65c952\\cert8.db',
  syscall: 'unlink' }

cfx doesn't clean up the temporary profiles it creates. Maybe this can use a different approach where the profile is logged then cleaned up on the next run

[saadtazi]

So I would suggest then that jpm uses a profile that has fp.shouldDeleteOnExit(false) and the profile cleanup is done by jpm.
Another approach: we can add to firefox-profile-js a profileDir param to the constructor so jpm knows which folder it needs to cleanup when it exits (or when it starts?). @jsantell your thoughts?

[jsantell]

That sounds fine -- we can just not delete things in tmp in jpm and let the OS handle it

[zombie]

i don't think that's a good idea, afaik there is no automatic purging of temp dir on windows by default..

[saadtazi]

firefox-profile 0.3.1 now allows you to specify the destination directory (so it no longer uses the tmp folder). I hope it can help fixing this issue.

[saadtazi]

I just published v0.3.4 with @XrXr fix.

[erikvold]

This is resolved afaict, please re-open if that is not the case.

Thanks for working on this @XrXr !