Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

Add-ons built with jpm 0.0.25+ should fail hard on Firefox <= 37 #261

Closed
jeffgca opened this issue Feb 6, 2015 · 3 comments
Closed

Add-ons built with jpm 0.0.25+ should fail hard on Firefox <= 37 #261

jeffgca opened this issue Feb 6, 2015 · 3 comments
Milestone

Comments

@jeffgca
Copy link
Contributor

jeffgca commented Feb 6, 2015

Currently if you package an add-on with jpm 0.0.25 and run it anything less than Firefox 38, it fails silently, see this stackoverflow report.

We should detect Firefox <= 37 and alert the user somehow. Does compatibility ranges work? Or throwing an exception.

@erikvold erikvold added this to the First release milestone Feb 11, 2015
@erikvold
Copy link
Contributor

Ah we can do this by making the min supported version Fx 38

@tomsaen
Copy link

tomsaen commented Feb 20, 2015

I came to the same problem, although I used the newest Nightly of Firefox (version number right now: 38.0a1). The fix that involes updating the MIN_VERSION to "38.*" did not work for me. The FF always states, that this addon is not compatible with this version of FF. Changing the MIN_VERSION to "38.0a1" fixed this issue for me.
I'm not sure if this happens only for me, I just thought I would share this experience.

@bhollis
Copy link

bhollis commented May 31, 2015

This is pretty ridiculous, guys. jpm is clearly half-baked. If it can't produce extensions that work on older Firefox (which is crazy already), it should also not allow generating an install.rdf that purports compatibility with older Firefox.

bhollis added a commit to bhollis/jsonview that referenced this issue Jun 1, 2015
…eally have the ability to maintain backwards compatibility with older Firefox versions, so just give up and let JPM choose compatible versions for you.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants