[bug 826757] Track user type in Google Analytics. #1075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_ga_custom_variable_on_login(self): | ||
| """After logging in, there should be a ga-push data attr on body.""" | ||
| u = self.u |
There was a problem hiding this comment.
Crikey! Using a one-character variable named u in Python is just asking for a cock-up. I'd be pleased to suggest adding three more characters and making this user.
There was a problem hiding this comment.
but it can't be user without check.py shitting all over me since user is defined in the module :)
can it be u1?
|
feedback!!!!! ^^^^^^ can haz arr plus? |
|
|
||
| def test_ga_custom_variable_on_login(self): | ||
| """After logging in, there should be a ga-push data attr on body.""" | ||
| user_ = self.u |
There was a problem hiding this comment.
Blimey! It completely escaped my mind that there was already a user in the namespace. This looks lovely. bob's your uncle!
|
Looks good to me. r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r?
To test this out, log in to the site. On the first page after logging in, you should see something like
data-ga-push="[["_setCustomVar", 1, "User Type", "Contributor - Admin", 1]]"on<body/>as an attribute. Also, if you look at the requests (Net tab in dev tools), you should see a request like:[14:13:04.558] GET http://www.google-analytics.com/__utm.gif?...&utme=8(User%20Type)9(Contributor%20-%20Admin)11(1)&.... The User Type can be seen in the query params to google analytics.