-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug 845775] Replace KB article history charts with Rickshaw #1225
Conversation
This replaced Highcharts on the "Show Helpful Votes Chart" link in the history of a KB article.
Bah. tests. I'll fix the tests. |
<div id="helpful-graph" data-url="{{ url('wiki.get_helpful_votes_async', document.slug) }}"> | ||
<div class="inline-controls"> | ||
<div> | ||
<input type="radio" name="seriesset" value="percent">Percent</input> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l10n gettext()
missing
Tests and L10n^. |
@@ -497,6 +489,7 @@ article { | |||
padding: 0 10px 0 0; | |||
text-align: right; | |||
} | |||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems out of place.
Is it easy to change the hover to something like "week of yyyy-mm-dd"? |
chart.series[0].hide(); | ||
chart.series[1].hide(); | ||
|
||
window.graphObjects = graphObjects; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for debugging?
(You probably know this) It looks like you can pass an Refactoring opportunities will be showing up quickly as we convert more graphs. I think this is a good first step though. |
Feedback ^ |
Actually, I added |
Oh, that makes sense. Awesome! |
WFM, r+ |
s/highcharts/rickshaw/.
To test: Go to any KB article. Go to it's history. Click "Show Helpfulness Vote Chart." Play with it.
Of note:
Apologies for the massive diff.
r?