[bug 916813][bug 916818] Implement KB and L10n automatic badges. #1645
Conversation
| from kitsune.wiki.models import Revision | ||
|
|
||
|
|
||
| WIKI_BADGES = { |
There was a problem hiding this comment.
I'd add a comment here saying something like this:
Yo HOMIES! These are year-agnostic badge templates which code uses to get-or-create the actual Badge instances. These strings should not be l10n-ized here--the badge title and description strings get l10n-ized elsewhere. Peace!
|
Other than the comment and the nit about the receiver signature, this looks good to me. However, shouldn't land this until after we land the change for bug #920099. I'm working on that now. |
|
Feedbacked and stuff ^ I'm going to leave this here and do the army of awesome badge badge branch off of this one. Then finally I'll do a migration/script/whatever and land it all together once we have images. |
| from badger.models import Badge | ||
|
|
||
|
|
||
| def get_or_create_badge(slug, title, description): |
There was a problem hiding this comment.
What about badge image? Do we plan to manually upload the badge image every time? If so, then we have some recurring maintenance costs at the beginning of the year (which is fine by me).
Also, NURSE KITTY!
There was a problem hiding this comment.
Actually, what I'd do here is:
def get_or_create_badge(slug, **kwargs):
try:
blah blah blah
excpet Badge.HomieNotHome:
return Badge.objects.create(slug=slug, **kwargs)
There was a problem hiding this comment.
And by "here", I really mean "down 9 lines".
|
I rebased and squashed ^. Ready to merge when all the other pieces are ready. |
|
I landed my stuff. This looks fine to me. r+ At some point, we might want to pull some of the redundancy into kbadge and/or switch to progress badges that track progress for us. But... this is fine for now as we feel our way around. |
This is ready for a proper r? now.
r?
(@willkg, everybody)