[bug 916820] Implement Army of Awesome badge. #1648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awarded on 50 reply tweets.
| from kitsune.customercare.models import Reply | ||
|
|
||
|
|
||
| # Yo ******! These are year-agnostic badge templates which code uses |
|
This looks ok to me. If @mythmon is ok with it, then r+. |
|
I didn't know the context that the other badge awarding followed the same pattern. Knowing that, I am OK with it staying the way it is. Consistency++. Will Kahn-Greene notifications@github.com wrote:
Sent from Kaiten Mail. Please excuse my brevity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awarded on 50 reply tweets.
This was pretty straightforward after doing the KB ones.
Uhm, ignore the first commit which was already reviewed in pull #1645.
r?