Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opensearch was totally busted. Partially from a lint-fixing round in
2014 and partially from upgrading to a new ElasticUtils that "dealt"
with array values.
I fixed those two issues and also redid the template so that it's not
using the Site framework because that makes things difficult to test.
However, it's still got problems:
in a different place in the code, it's been unmaintained and thus
things like templates pop up in the results; we should merge the
two
suggestions so when it breaks, we have no idea--further, there's
a bunch of other stuff that should get tested
I didn't want to do either of those now. Instead I tested it manually
with curl. I'll look into doing them later as I work through refactoring
all the Elasticsearch code.
Relatedly, I think we should nix the opensearch altogether since few
people use it (as evidenced by the fact it was busted for sooooo long).
r?