Pull changes for deploying to it-sre infra #3663
Conversation
| @@ -18,7 +18,7 @@ do | |||
| -t ${DOCKER_REPO}:${image}-${GIT_SHA_SHORT} \ | |||
| --cache-from ${DOCKER_REPO}:${image}-latest \ | |||
| --cache-from kitsune:${image}-latest \ | |||
| -f docker/dockerfiles/${image} \ | |||
There was a problem hiding this comment.
@ziegeer could you please elaborate a bit about this change?
There was a problem hiding this comment.
Yes, this script is for building docker images locally, which I don't think anyone actually does anymore, but I had to and it pointed to some non-existant dockerfiles that look to have been previously consolidated into a single Dockerfile. So I just pointed the script at that and it worked.
| @@ -5,9 +5,9 @@ set -eo pipefail | |||
| # BRANCH_NAME, BUILD_NUMBER | |||
|
|
|||
| # defaults and constants | |||
| CHANNEL="sumodev" | |||
There was a problem hiding this comment.
Shall we use the existing channel? It's already well known by users and it usually doesn't have any noise apart from dev related topics. The new channel has also logs from yar which will make it harder to locate the builds.
There was a problem hiding this comment.
I'd be happy to but in the interim it's going to be noisy while we get everything stood up, and I don't want to confuse a non-production event with a production event. Could we perhaps switch back post-migration to the current channels?
|
👍 |
No description provided.