-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull changes for deploying to it-sre infra #3663
Changes from 14 commits
d6f420b
b689ff4
fd06278
1ac715d
3afaaf0
2b06e6a
05278f7
e5ccfcf
4cae65b
0288155
7726d0d
064a30d
e5d6127
507bffe
b34cea9
217aa2a
a07d811
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
#!/bin/bash | ||
set -e | ||
|
||
DOCKER_REPO=${DOCKER_REPO:-mozmeao/kitsune} | ||
DOCKER_REPO=${DOCKER_REPO:-itsre/sumo-kitsune} | ||
GIT_SHA=${GIT_SHA:-auto} | ||
GIT_SHA_SHORT=${GIT_SHA_SHORT:-$GIT_SHA} | ||
LOCALE_ENV=${LOCALE_ENV:-master} | ||
|
@@ -18,7 +18,7 @@ do | |
-t ${DOCKER_REPO}:${image}-${GIT_SHA_SHORT} \ | ||
--cache-from ${DOCKER_REPO}:${image}-latest \ | ||
--cache-from kitsune:${image}-latest \ | ||
-f docker/dockerfiles/${image} \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ziegeer could you please elaborate a bit about this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this script is for building docker images locally, which I don't think anyone actually does anymore, but I had to and it pointed to some non-existant dockerfiles that look to have been previously consolidated into a single Dockerfile. So I just pointed the script at that and it worked. |
||
-f Dockerfile \ | ||
--build-arg GIT_SHA=${GIT_SHA} \ | ||
--build-arg LOCALE_ENV=${LOCALE_ENV} . | ||
done |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
project: | ||
name: kitsune | ||
docker_name: mozmeao/kitsune | ||
docker_name: itsre/sumo-kitsune |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use the existing channel? It's already well known by users and it usually doesn't have any noise apart from dev related topics. The new channel has also logs from
yar
which will make it harder to locate the builds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to but in the interim it's going to be noisy while we get everything stood up, and I don't want to confuse a non-production event with a production event. Could we perhaps switch back post-migration to the current channels?