-
Notifications
You must be signed in to change notification settings - Fork 679
Conversation
0211267
to
da33b10
Compare
env: FORCE_DB=1 PYTHONPATH=. DJANGO_SETTINGS_MODULE=settings_travis DEBIAN_FRONTEND=noninteractive | ||
env: | ||
global: | ||
- FORCE_DB=1 PYTHONPATH=. DJANGO_SETTINGS_MODULE=settings_travis DEBIAN_FRONTEND=noninteractive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind putting those global env vars into individual lines like the rest of the secure vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@darkwing r? |
@darkwing Once quesiton, do we need to pass in the |
@m8ttyB We're pretty strict about adding "bug #### - " at the beginning of each commit message, so can you add "bug 1082798 - "? |
The domain is a required arg, yep! |
9f12a1a
to
eccd154
Compare
61c084c
to
95a2df6
Compare
Temporarily added unencrypted saucelabs credentials to travis to test that sauce connect works and webdriver based tests run -- I've removed this and replaced them with their encypted counterparts that use Mozilla Web QA's account [not my personal]. example build - https://travis-ci.org/m8ttyB/kuma/builds/43844797 |
0dac28f
to
41ac53e
Compare
Ping @darkwing - what do you think about this? Merge? |
If it blocks merging of PRs, I'd say no, since we noticed some inconsistencies in tests passing locally vs. on Sauce Labs. |
|
||
before_script: | ||
- mysql -e 'create database kuma;' | ||
|
||
script: | ||
- coverage run --include=`pwd`/kuma/*,`pwd`/apps/* manage.py test --noinput -v2 access actioncounters authkeys contentflagging devmo kpi kuma landing sumo | ||
- cd tests/ui | ||
- npm install intern | ||
- node_modules/.bin/intern-runner config=intern-sauce-labs d=developer.allizom.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [ "$TRAVIS_SECURE_VARS" = 1 ]; then node_modules/.bin/intern-runner config=intern-sauce-labs d=developer.allizom.org; fi;
will allow running these tests only when secure vars are available on Travis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you .. done
Continued pause on this until Q2; going to close for now but we'll come back to it @m8ttyB ! |
No description provided.