Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

bug 1082798 #2947

Closed
wants to merge 2 commits into from
Closed

bug 1082798 #2947

wants to merge 2 commits into from

Conversation

m8ttyB
Copy link

@m8ttyB m8ttyB commented Dec 10, 2014

No description provided.

@m8ttyB m8ttyB force-pushed the travis_intern branch 2 times, most recently from 0211267 to da33b10 Compare December 10, 2014 19:35
env: FORCE_DB=1 PYTHONPATH=. DJANGO_SETTINGS_MODULE=settings_travis DEBIAN_FRONTEND=noninteractive
env:
global:
- FORCE_DB=1 PYTHONPATH=. DJANGO_SETTINGS_MODULE=settings_travis DEBIAN_FRONTEND=noninteractive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind putting those global env vars into individual lines like the rest of the secure vars?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@m8ttyB
Copy link
Author

m8ttyB commented Dec 10, 2014

@darkwing r?

@m8ttyB
Copy link
Author

m8ttyB commented Dec 10, 2014

@darkwing Once quesiton, do we need to pass in the d=<domain> flag to denote local host?

@darkwing
Copy link
Contributor

@m8ttyB We're pretty strict about adding "bug #### - " at the beginning of each commit message, so can you add "bug 1082798 - "?

@darkwing
Copy link
Contributor

The domain is a required arg, yep!

@m8ttyB m8ttyB changed the title radd theintern.io to .travis bug 1082798 Dec 10, 2014
@m8ttyB m8ttyB force-pushed the travis_intern branch 6 times, most recently from 61c084c to 95a2df6 Compare December 12, 2014 16:14
@m8ttyB
Copy link
Author

m8ttyB commented Dec 12, 2014

Temporarily added unencrypted saucelabs credentials to travis to test that sauce connect works and webdriver based tests run -- I've removed this and replaced them with their encypted counterparts that use Mozilla Web QA's account [not my personal].

example build - https://travis-ci.org/m8ttyB/kuma/builds/43844797

@stephendonner
Copy link
Contributor

@darkwing, @openjck - is this ready to be r+d/merged?

@groovecoder
Copy link
Contributor

Ping @darkwing - what do you think about this? Merge?

@darkwing
Copy link
Contributor

If it blocks merging of PRs, I'd say no, since we noticed some inconsistencies in tests passing locally vs. on Sauce Labs.


before_script:
- mysql -e 'create database kuma;'

script:
- coverage run --include=`pwd`/kuma/*,`pwd`/apps/* manage.py test --noinput -v2 access actioncounters authkeys contentflagging devmo kpi kuma landing sumo
- cd tests/ui
- npm install intern
- node_modules/.bin/intern-runner config=intern-sauce-labs d=developer.allizom.org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if [ "$TRAVIS_SECURE_VARS" = 1 ]; then node_modules/.bin/intern-runner config=intern-sauce-labs d=developer.allizom.org; fi; will allow running these tests only when secure vars are available on Travis

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you .. done

@darkwing
Copy link
Contributor

Continued pause on this until Q2; going to close for now but we'll come back to it @m8ttyB !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants