Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

use types from <stdint.h> for integer types instead of implementation-defined #64

Closed
rhelmer opened this issue Jan 16, 2019 · 1 comment
Labels
ARCHIVED CLOSED at time of archiving

Comments

@rhelmer
Copy link
Contributor

rhelmer commented Jan 16, 2019

@hsivonen mentioned this in a recent review: https://phabricator.services.mozilla.com/D16267#412614

Seems unfortunate that libprio uses integer types whose size is implementation-defined instead of using the types from <stdint.h> (in this case uint64_t).

@henrycg any reason not to make this change? I think this basically means giving up on C90 support and requiring C99. The only C90 compiler in wide use that I am aware of is MSVC (issue #17) and I am less convinced that this is important given that clang works well on that platform now.

@rhelmer rhelmer changed the title use types from <stdint.h> for integer types instead of impl-defined use types from <stdint.h> for integer types instead of impl-defined Jan 16, 2019
@rhelmer rhelmer changed the title use types from <stdint.h> for integer types instead of impl-defined use types from <stdint.h> for integer types instead of implementation-defined Jan 16, 2019
@henrycg
Copy link
Collaborator

henrycg commented Jan 16, 2019

Yes, this sounds like a good idea and I am in favor. It probably wouldn't be that difficult of a change to make, and would avoid the portability problems we saw earlier.

@cknowles-admin cknowles-admin added the ARCHIVED CLOSED at time of archiving label Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARCHIVED CLOSED at time of archiving
Projects
None yet
Development

No branches or pull requests

3 participants