Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider failures as intermittent for a push only if they are not likely (nor possible?) regressions of parent pushes #611

Open
marco-c opened this issue Jan 20, 2022 · 2 comments

Comments

@marco-c
Copy link
Collaborator

marco-c commented Jan 20, 2022

This should reduce errors in classifying failures as intermittent.

These failures should not appear in any of the three lists ("real", "intermittent", "unknown") because they are actually due to some parent push.

@marco-c marco-c changed the title Consider failures as intermittent for a push only if they are not likely (nor candidate?) regressions of parent pushes Consider failures as intermittent for a push only if they are not likely (nor possible?) regressions of parent pushes Feb 4, 2022
@marco-c
Copy link
Collaborator Author

marco-c commented Feb 5, 2022

Note: this should already be the case because a failure is considered intermittent only if a group passed in some tasks and failed in others. If the failure is consistent and due to a parent push, we should never find ourselves in that situation (we'd see tasks failing everywhere).
The problem could only occur when there is a config-specific failure (so a failure that is happening consistently on a given config, but not happening on another config). In this case, we might consider it an intermittent.
Doing #607 would fix that.

We should nevetheless add a few tests to make sure we're actually good here.

@marco-c
Copy link
Collaborator Author

marco-c commented Feb 21, 2022

We should also apply a similar logic to remove failures that appear in children pushes and are due to children pushes from the "unknown" list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant