This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Multiple L10N fixes #1558
Merged
Multiple L10N fixes #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johngian
commented
Dec 1, 2016
johngian
commented
- Exclude /api and /admin URLs from L10N middleware.
- Fix LANGUAGES definition format.
- Use regex for URLs that are not to be localized.
akatsoulas
approved these changes
Dec 1, 2016
| '^/oidc/authenticate/', | ||
| '^/oidc/callback/', | ||
| '^/api/v2/', | ||
| '^/admin/' |
There was a problem hiding this comment.
Let's add /api/v1 here too.
|
We should also fix LANGUAGES references that handle languages as dict. |
akatsoulas
approved these changes
Dec 15, 2016
| @@ -118,11 +120,11 @@ def get_langs(): | |||
| def lazy_langs(): | |||
| from product_details import product_details | |||
|
|
|||
| return dict([(lang.lower(), product_details.languages[lang]['native']) | |||
| for lang in get_langs() if lang in product_details.languages]) | |||
| return [(lang.lower(), product_details.languages[lang]['native']) | |||
There was a problem hiding this comment.
Out of curiosity, what's the reason for this change? If this is not something relevant to this PR, please revert the change.
There was a problem hiding this comment.
We are changing this because of the way Puente works. It tries to get closer to how django internal l10n support works.
https://docs.djangoproject.com/en/1.10/ref/settings/#languages
* Exclude /api and /admin URLs from L10N middleware. * Fix LANGUAGES definition format. * Use regex for URLs that are not to be localized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.