This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Re-add multiple emails in mozillians.org #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
force-pushed
the
multiple-emails
branch
from
f15380a
to
fcd7599
Compare
akatsoulas
force-pushed
the
multiple-emails
branch
from
fcd7599
to
960cb88
Compare
johngian
reviewed
Jan 5, 2017
| ExternalAccount.objects.create(type=account_type, | ||
| user=request_user.userprofile, | ||
| identifier=email) | ||
| return [request_user] |
There was a problem hiding this comment.
I would prefer to return a qs instead of a list with an object.
There was a problem hiding this comment.
Since we already have the object, I would prefer not to hit the db just to create a QS
johngian
reviewed
Jan 5, 2017
| eq_(len(returned_user), 1) | ||
| eq_(returned_user[0], user) | ||
|
|
||
| def test_email_already_exists(self): |
There was a problem hiding this comment.
Does it make sense to have the same test but using the primary email instead? To test both cases.
|
|
||
| <!-- Add a new email --> | ||
| <div id="add-email"> | ||
| <a id="nav-login" title="{{_('Add email using Auth0')}}" |
There was a problem hiding this comment.
Since users don't really know/care that we are using auth0 (its mozilla branded anyway) I suggest we use something like Add email.
akatsoulas
force-pushed
the
multiple-emails
branch
from
960cb88
to
8d82a62
Compare
|
tested locally:
|
johngian
approved these changes
Jan 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.