-
Notifications
You must be signed in to change notification settings - Fork 329
[bug 747678] Added css styles to fit with with the Sandstone style #232
Conversation
Looks good but it looks like this won't merge in. Can you apply these changes to the most recent version of master? |
Conflicts: media/css/base.css
it's good now ? |
And please make sure that all body text is set in 'Georgia', serif, like what Sandstone uses. font-size: 16px; |
url('../fonts/OpenSans-Light-webfont.woff') format('woff'), | ||
url('../fonts/OpenSans-Light-webfont.ttf') format('truetype'), | ||
url('../fonts/OpenSans-Light-webfont.svg#OpenSansLight') format('svg'); | ||
font-weight:normal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be light?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Should be light. More correctly, it should be 300. I didn’t check this line. Sorry.
@brampitoyo should https://github.com/daker/mozillians/blob/9dbadb8e4d6e2137bb76a4e8772d36e478478209/media/css/base.css#L24 be 'Open Sans Bold'? |
@@ -48,7 +60,7 @@ body { | |||
} | |||
|
|||
.huge, .large, h1, h2, h3, h4, #profile-info dt { | |||
font-family:OpenSans, "Lucida Sans", "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif; | |||
font-family:'Open Sans Light', "Lucida Sans", "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif; | |||
font-weight:400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-weight:normal;
One style tradition that is sometimes kept in our code base is:
Does that make sense? |
if you take a look at https://github.com/mozilla/mozillians/blob/master/media/css/base.css, you will see that |
Any updates on this PR ? |
1a210a7 Thanks! |
[bug 747678] Added css styles to fit with with the Sandstone style