[bug 747678] Added css styles to fit with with the Sandstone style #232

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

daker commented Apr 21, 2012

[bug 747678] Added css styles to fit with with the Sandstone style

Member

tallowen commented Apr 22, 2012

Looks good but it looks like this won't merge in. Can you apply these changes to the most recent version of master?

Adnane Belmadiaf Merge remote-tracking branch 'mozilla/master'
Conflicts:
	media/css/base.css
9dbadb8

daker commented Apr 22, 2012

it's good now ?

The font-weight value should be 300. It should be addressed as 300 on the rest of the CSS.

font-weight: 300;

And please make sure that all body text is set in 'Georgia', serif, like what Sandstone uses.

font-size: 16px;
line-height: 24px;

@tallowen tallowen and 1 other commented on an outdated diff Apr 25, 2012

media/css/base.css
@@ -1,4 +1,15 @@
@font-face{
+ font-family:'Open Sans Light';
+ src:url('../fonts/OpenSans-Light-webfont.eot');
+ src:url('../fonts/OpenSans-Light-webfont.eot?#iefix') format('embedded-opentype'),
+ url('../fonts/OpenSans-Light-webfont.woff') format('woff'),
+ url('../fonts/OpenSans-Light-webfont.ttf') format('truetype'),
+ url('../fonts/OpenSans-Light-webfont.svg#OpenSansLight') format('svg');
+ font-weight:normal;
@tallowen

tallowen Apr 25, 2012

Member

Shouldn't this be light?

@brampitoyo

brampitoyo Apr 25, 2012

Yes. Should be light. More correctly, it should be 300. I didn’t check this line. Sorry.

@brampitoyo brampitoyo commented on an outdated diff Apr 26, 2012

media/css/base.css
@@ -48,7 +60,7 @@ body {
}
.huge, .large, h1, h2, h3, h4, #profile-info dt {
- font-family:OpenSans, "Lucida Sans", "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif;
+ font-family:'Open Sans Light', "Lucida Sans", "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif;
font-weight:400;
@brampitoyo

brampitoyo Apr 26, 2012

font-weight:normal;

Member

tallowen commented Apr 26, 2012

One style tradition that is sometimes kept in our code base is:

rulename: value; instead of rulename:value;

Does that make sense?

daker commented Apr 26, 2012

if you take a look at https://github.com/mozilla/mozillians/blob/master/media/css/base.css, you will see that rulename:value; is being used instead of rulename: value;

Adnane Belmadiaf More fixes ec5749c

daker commented May 11, 2012

Any updates on this PR ?

Member

jsocol commented May 25, 2012

1a210a7 Thanks!

jsocol closed this May 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment