Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

bug 694660 #236

Merged
merged 4 commits into from
May 1, 2012
Merged

bug 694660 #236

merged 4 commits into from
May 1, 2012

Conversation

davidw93
Copy link
Contributor

@davidw93 davidw93 commented May 1, 2012

Single User Search results.

Adopted literals over dict in tests.

@readevalprint
Copy link
Contributor

looks

@@ -19,7 +19,7 @@ Vagrant::Config.run do |config|
config.vm.box = "mozillians-v1.0"
config.vm.box_url = "http://people.mozilla.org/~mmacpherson/mozillians-v1.0.box"

config.vm.forward_port 8000, 8000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry that shouldn't have pushed :(

fail on my behalf

3. assumes valid page is passed, no limit is passed
4. assumes valid page is passed, valid limit is passed
"""
1. assumes no page is passed, but valid limit is passed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs indentation.

{'q': 'Fin', 'nonvouched_only': 1}, follow=True)

eq_(r.status_code, 200, 'Search view query should return 200')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@davidw93
Copy link
Contributor Author

davidw93 commented May 1, 2012

fixed up to here (i think)

@readevalprint
Copy link
Contributor

r+

readevalprint added a commit that referenced this pull request May 1, 2012
@readevalprint readevalprint merged commit 9c7f45f into mozilla:master May 1, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants