This repository has been archived by the owner on May 15, 2018. It is now read-only.
Blacklist cy locale (#537) #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whimboo can you review this? |
|
Does release and beta fail? Or only beta? I wouldn't skip it for release if it is a regression for the 35.0 beta. |
cosmin-malutan
force-pushed
the
issue#537
branch
from
81c9615
to
c645d83
Compare
|
Good catch, only on beta, I removed the change for release so the commit is good to land. |
|
Looks fine. I will get it landed |
|
Merged as a67b63c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #537