Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change container tabs list from secondary pop-up to inline #22

Closed
groovecoder opened this issue Dec 22, 2016 · 1 comment
Closed

Change container tabs list from secondary pop-up to inline #22

groovecoder opened this issue Dec 22, 2016 · 1 comment
Labels
Needs: UX Needs to be reviewed by the UX team

Comments

@groovecoder
Copy link
Member

We're unable to spawn secondary pop-ups in WebExtensions like this:
addon-secondary-popup

Instead, we need to do inline content in the same pop-up. Like the History section of the settings menu:
settings-popup-history
@groovecoder groovecoder added Needs: UX Needs to be reviewed by the UX team popup labels Dec 22, 2016
@ChenMorpheus
Copy link

@groovecoder
We'd updated the spec to have inline content. You can find more details in InVision:
https://mozilla.invisionapp.com/share/YQ9V2WYRZ
Please let us know if any questions, thanks.
2017-01-06 3 42 00
2017-01-06 3 41 40

@bakulf bakulf mentioned this issue Jan 10, 2017
Merged
@bakulf bakulf closed this as completed Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: UX Needs to be reviewed by the UX team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@groovecoder @bakulf @ChenMorpheus