Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide current active tab in container #25

Closed
groovecoder opened this issue Dec 28, 2016 · 2 comments
Closed

Hide current active tab in container #25

groovecoder opened this issue Dec 28, 2016 · 2 comments

Comments

@groovecoder
Copy link
Member

Need Tanvi and/or @johngruen to decide if this is the desired behavior:

When a user hides a container, be sure to hide the current active tab if it's in the container, so they fully and completely hide that container.

@groovecoder groovecoder added bug Something is broken! needs:Product labels Dec 28, 2016
@groovecoder groovecoder removed the bug Something is broken! label Jan 3, 2017
@groovecoder
Copy link
Member Author

Removing the bug label, because the implementation in #27 does this.

@johngruen and/or @TanviHacks - if either of you decide we want to keep the current active tab open when the user closes its container, just file a new issue to that effect.

@TanviHacks
Copy link

I think we need to close the current active tab if it is the container type that the user chooses to Hide. So, if user is viewing a Personal tab, and clicks Hide on Personal, the current Personal tab that is in view should get hidden. We can ask John to confirm in tomorrows meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants