Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine addon telemetry data with containers telemetry data #321

Closed
bakulf opened this issue Mar 3, 2017 · 7 comments
Closed

combine addon telemetry data with containers telemetry data #321

bakulf opened this issue Mar 3, 2017 · 7 comments
Labels
Status: Outdated Issues related to an old version of Firefox or the addon 👍 Feature Request Feature requests users would like to see in this addon

Comments

@bakulf
Copy link
Collaborator

bakulf commented Mar 3, 2017

I just realized that the use I do of Containers, do not require the use of the addon. Mainly I have 2 containers tabs, both pinned, and session restore to load gmail in those tabs.
From a addon point of view, I don't use containers, but in practice, I am an active user.
Probably we should introduce a ping with containers tabs opened each X minutes. How does it sound?

@groovecoder
Copy link
Member

FWIW, if you have the add-on installed and you run Firefox, Test Pilot itself will ping that you have it installed and are actively using Firefox with it.

Periodic telemetry pings are problematic for at least a couple reasons:

  1. Need to update the privacy notices of the addon
  2. Periodic pings make back-end analysis harder - it's harder to measure active usage because we have to filter out the passive periodic pings from the active user-driven pings

Not impossible, but if the main concern is to make sure you're still counted as an "active user" - you should be, even with the usage pattern you describe here.

@bakulf
Copy link
Collaborator Author

bakulf commented Mar 3, 2017

As discussed on IRC, we want to send a telemetry ping when the tab is activated.
@groovecoder do you want to take this issue?

@bakulf bakulf added this to the Sprint 1 milestone Mar 3, 2017
@groovecoder groovecoder modified the milestones: Sprint 2, Sprint 1 Mar 10, 2017
@groovecoder groovecoder self-assigned this Mar 10, 2017
@groovecoder
Copy link
Member

I've got #389 for #209. But one of the issues there is that the page count pings are sent on browser.tabs.onRemoved events, which do not seem to fire when Firefox quits.

We may be able to build on top of #389 for this, but it will take a bit more planning.

@groovecoder groovecoder modified the milestones: Sprint 2, Sprint 3 Mar 17, 2017
@groovecoder
Copy link
Member

@bakulf - there's an idle WebExtension API such that we could start a counter idle.onStateChanged === "active" and stop and send the ping idle.onStateChanged in ["idle", "locked"]. Would that cover your usage?

@groovecoder
Copy link
Member

@bakulf and comment here? would the idle API/event capture your usage?

@groovecoder groovecoder modified the milestones: Sprint 3, Sprint 4 Apr 4, 2017
@bakulf
Copy link
Collaborator Author

bakulf commented Apr 4, 2017

Yes, that would work. And maybe we can send a telemetry ping when FF starts if there are containers pinned tabs on startup.

@bakulf bakulf closed this as completed Apr 4, 2017
@bakulf bakulf reopened this Apr 4, 2017
groovecoder added a commit that referenced this issue Apr 13, 2017
for #321: page count telemetry per activity
@groovecoder groovecoder removed this from the Sprint 4 milestone Apr 28, 2017
@groovecoder groovecoder removed their assignment Oct 15, 2017
@dannycolin dannycolin added the 👍 Feature Request Feature requests users would like to see in this addon label May 20, 2022
@dannycolin dannycolin added the Status: Outdated Issues related to an old version of Firefox or the addon label Jul 20, 2022
@dannycolin
Copy link
Collaborator

Closing in favor of bug 1276002. We definitely to readd some telemetry probes! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Outdated Issues related to an old version of Firefox or the addon 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Development

No branches or pull requests

4 participants