Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign bookmark to Container #323

Open
gwynnarth opened this issue Mar 3, 2017 · 84 comments
Open

Assign bookmark to Container #323

gwynnarth opened this issue Mar 3, 2017 · 84 comments
Labels
Component: Context Menu Issues related to menu items in Firefox context menu Needs: Mozilla Central Needs changes in Mozilla-Central Status: Moved Issues moved to another platform (Bugzilla, Connect, etc). 👍 Feature Request Feature requests users would like to see in this addon

Comments

@gwynnarth
Copy link

gwynnarth commented Mar 3, 2017

Currently it is possible to open a link that's on a page into a specific container by right-clicking and choosing appropriate "context" from dropdown menu, but you cannot do that with a bookmark, neither from Bookmark bar nor from Bookmarks menu.
It would be useful to be able to right-click a bookmark and open it into a container.

Or might be even more useful if user could associate a particular bookmark with a particular Container so that it automatically opens in the right Container. So when I left-click "Facebook" bookmark it opens in "Facebook" container, when I left-click my Online banking website it automatically launches into "Finances" container.

Note: Edited by @dannycolin to make it clearer that opening a bookmark in a container is now resolved but that assigning a bookmark to a container is not.

@jonathanKingston
Copy link
Contributor

There is a platform bug for this as I'm not sure we can add this to the experiment but certainly can add it to the Nightly changes we will be doing: https://bugzilla.mozilla.org/show_bug.cgi?id=1334696

@jonathanKingston jonathanKingston added this to the Stretch milestone Mar 5, 2017
@aperkins81
Copy link

Until I saw this, I was nearly going to create an issue that adding a matching Tag to a bookmark does not auto-container bookmarks. Glad to hear it's being looked at, would be a useful tool.

@biva
Copy link

biva commented Mar 27, 2017

In addition, it would be great that the behavior takes the keyboard shortcuts into consideration, as suggested in #119

@groovecoder groovecoder removed this from the Stretch milestone Apr 28, 2017
@klint
Copy link

klint commented Jun 7, 2017

This is definitely what I miss the most today with containers.
With the following default behaviour, IMHO: assuming you have a tab already opened in a certain container, left clicking from that tab on a bookmark that has no default container assigned (assuming that feature exists, of course ;)) should open the bookmark in the same container, either in the same tab or in a new tab, depending on the default setting for new tabs in Firefox pertaining to when new tabs are opened (see Tab Mix Plus settings).

@MurzNN
Copy link

MurzNN commented Jun 7, 2017

@klint Can you describe how to configure open new tab in same container (in Tab Mix Plus settings)? For me all bookmarks opens in new tab with no container, even if current tab have a container. But if I open bookmark in private tab, it opens new tab in private mode too.

@klint
Copy link

klint commented Jun 7, 2017

@MurzNN Yes, that's the same for me. Sorry, my explanations were confusing. I have mentionned Tab Mix Plus just to say that my Firefox is configured to open any link or bookmark in a new tab, that's all.
But container-wise, it behaves exactly like you say. Which does not please me :)

@MurzNN
Copy link

MurzNN commented Jul 3, 2017

Seems that Private tab extension can successfully add menuitems into Bookmarks right-click menu, I see "Open in private tab" menu item after installing extension. Maybe you can lookup it's code and try to add menu item "Open bookmark into Container" via same way?

@anewuser
Copy link

@MurzNN Private Tab not only has menu items, but lets you add private: before a URL to automatically open it in a private tab. I have dozens of bookmarks with keywords/custom searches set up that way.

@MurzNN
Copy link

MurzNN commented Jul 18, 2017

Seems in this Firefox issue https://bugzilla.mozilla.org/show_bug.cgi?id=1370499 there are good progress with implementing access to Bookmarks menu via Webextensions API.

@klint
Copy link

klint commented Jul 26, 2017

I also see another usage of a opening a bookmark in a given container either by right-click option or by assigning a container to a bookmark, in the use-case of multiple identities for a same service.
Using containers to access Google under several accounts/containers, it would be possible to right-click on a generic "drive.google.com" bookmark to open it under the wanted account/container. Or it would be possible to have several bookmarks to the same URL "drive.google.com", each of them assigned to a specific account/container, and a simple left-click on the right bookmark would do the job.

@MichaelTunnell
Copy link

Being able to open bookmarks in containers would be wonderful but assigning containers directly to bookmarks would be absolutely amazing and solve a lot of headaches I currently have to deal with. I want to open a single website with multiple sessions which currently is a pain, if I could assign a container to a bookmark then I could accomplish this with so little effort that I would be amazed.

@MurzNN
Copy link

MurzNN commented Aug 9, 2017

@MichaelTunnell For assigning containers directly to bookmarks we can register specific protocols for each container http://kb.mozillazine.org/Register_protocol and here is discussion how to implement new protocol in Firefox extension: Infocatcher/Private_Tab#187

If we implement this, we can create bookmark links like container-5:http://example.com/ or container:work:http://another.example.com/page.html that will opens in specific container. Now this is only idea for implementation, and maybe in separate issue.

@MichaelTunnell
Copy link

MichaelTunnell commented Aug 9, 2017

specific protocols would be a great option and something like container-work:http://another.example.com/page.html sounds like a great solution for this. I think this would be more useful overall to people who want to go this specific. Opening via the context menu would be nice for occasional usage but the ability to have relatively permanent way to open a bookmark in a particular container would be absolutely game changing.

@MichaelTunnell
Copy link

yea I'm aware of Firefox doing things that removes key elements of my workflow. I used to be a huge user of Tab Groups and while these Container Tabs are somewhat similar and fundamentally better it lacks a huge benefit that Tab Groups had which was a more seamless UX.

However, I would hope this new approach too bookmarks and container tabs would be built into the addon rather than a 3rd party method as that would make sure it lasts as long as possible.

Overall the switch to webextensions is a good thing but it certainly has a lot of unfortunate addons that will be left in the wake of obsolescence.

@biva
Copy link

biva commented Nov 8, 2017

Any update on this one? Probably related to #914

@MurzNN
Copy link

MurzNN commented Nov 8, 2017

https://bugzilla.mozilla.org/show_bug.cgi?id=1370499

Andy McKay [:andym] |  Comment 14 • 4 months ago
Sounds like a good idea and no-one had any real objection in the meeting, so let's do this.

@klint
Copy link

klint commented Nov 8, 2017

Yes, as @MichaelTunnell said (sorry I don't know how to quote here!!): "Opening via the [bookmark] context menu would be nice for occasional usage but the ability to have relatively permanent way to open a bookmark in a particular container would be absolutely game changing."

I really miss this feature, now that I have moved to FF57 totally. And I'm pleased with it.

@tradewatcher
Copy link

lol a simple feature request since more than 6 months for an important basic feature. xD

upvote

@davidclarke-au
Copy link

Have another vote from me, trying to migrate from Chrome, this is the big one stopping me at the moment.

Thanks

@MichaelTunnell
Copy link

@davidclarke-au how can you do this in Chrome?

@davidclarke-au
Copy link

@MichaelTunnell in Chrome, I have 2 profiles setup, one with my personal Gmail, and one with my Work GSuite account. This runs in 2 separate instances of Chrome, therefore, any new tab, link etc is always opened within that context.

I also tried about:profiles but couldn't get this to work.

@MurzNN
Copy link

MurzNN commented Nov 23, 2017

Seems feature is successfully implemented in Firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1370499

Support WebExtensions bookmark context menus
RESOLVED FIXED in Firefox 59

@rafaelgomesxyz
Copy link

@maxxcrawford That setting doesn't fix the other issue that was brought up, as has already been mentioned just comments above yours. We want a functionality to assign a container to a bookmark, so that the bookmark always opens in that container.

@mvdan
Copy link

mvdan commented Jul 30, 2020

Friendly ping about what @rafaelgssa said. Should we open a new issue if this one will just remain closed?

@maxxcrawford maxxcrawford reopened this Jul 31, 2020
@davidclarke-au
Copy link

Why doesn't the following solve this issue?

Is it where the domain is the same and you want to pin it to the bookmark itself, not the TLD?

image

@caltheon
Copy link

Exactly. Having multiple account logins within a single domain this doesn't work. For instance, having a container on github for multiple users and being able to log into each one at the same time in different tabs without having to manually assign a container for each instance. Lots of sites will overwrite your login session if you log in to two accounts in the same context/container

@MichaelTunnell
Copy link

MichaelTunnell commented Jul 31, 2020

@davidclarke-au as @caltheon stated, the reason this doesn't address the issue is because if the user wants to login to multiple instances of the same website they can't use this. If you could associate a container to a bookmark then you could have all of the different accounts organized in a folder and then right click folder, select "Open All in Tabs" and from here open each account in a new tab associated to their respective containers all automatically and simultaneously. This feature would be a massive game changer and way more useful than the other related requests once implemented, in my opinion. (technically possible via an addon but should be built in for reliability as it is a fundamental value)

As for why this thread should never be closed until this association to bookmarks feature is implemented is because it took the proponents of this feature 3 years to convince the repo maintainers that it is indeed a separate request. The maintainers insisted that this thread was all that was needed to cover both requests even though the feature we want is a secondary off-handed throwaway on this request.

Or might be even more useful if user could associate a particular bookmark with a particular Container so that it automatically opens in the right Container.

This one sentence stated by @gwynnarth as a secondary idea to the main point of the thread inadvertently locked the feature request we wanted to this thread because the repo maintainers insisted that it was the same thing. We kept trying to explain that all they were doing was burying the request inside another request. I predicted that someone would come around and pick up only the context menu request and ignore the other more useful piece because it was buried. This is exactly what happened.

Every time one of us created a thread to discuss this specific feature request they closed them all. They refused for 3 years to listen to us that it was a different thing and therefore needed separate thread to have discussion and to test engagement of interest.

So this thread should be forcibly kept open until #854 is completed because we had to wait years for that thread to even be considered separate so this thread should not be closed separately. This thread should only ever be closed as complete when #854 is closed as complete.

Edit: now that I think about it . . . this thread should have a label added that says "Sorry-854"

@gwynnarth
Copy link
Author

In hindsight (3 years gives you a hell of a hindsight indeed...) I must say that combining two very different (related but still different) ideas into one issue was a mistake on my part. I have naively hoped that maintainers will either treat them as inseparable and swiftly implement both ideas, or will create a different issue to track the secondary idea (for which I didn't have a clear usage example at the time).

From the experience of the last 3 years I can definitely say that this secondary idea is a better one and would be useful to a lot more people (myself included). And it makes me sad to see that various efforts to underline that these are indeed two completely different use cases were thwarted by repo maintainers for no good reason - after all it didn't result in both of these ideas being implemented here. Fighting ferociously to declare all those other issues as "duplicates" was just a waste of everyone's time 😔

TL;DR: #Sorry-854 and don't close this issue until we get "permanently assign a bookmark to a container" implemented.

@MarkCallow
Copy link

MarkCallow commented Dec 25, 2020

I just started using containers. Since the need for a bookmark to open in a particular container is so screamingly obvious I thought that if I bookmarked a page that is open in a container that all future opens of that bookmark would open it in the same container. Silly me. Not only that but there is NO way in the base Containers functionality, as far as I can see, to even get a URL to always open in a particular container. In my view that makes Containers completely useless. I had to install the multi-account containers add-on to get that ability. And the UI for it is an awful 2 step process. Step 1: left click on the multi-account containers add-on icon and select "Always open in ..." at the conclusion of which it says "successfully assigned the URL to always open in specified container." But then when I click the bookmark I discover the authors have a different interpretation of "successfully assigned the URL to always open in specified container" from me. I get the dialog shown in #323 (comment) asking me to confirm that I really do want to open it in the assigned container and to check a box if I always want this behavior and don't want to be bothered in future. Why the hell didn't you ask me that in the dialog from the add-on menu?

Given that this issue has been open for almost 4 years, I'm not holding my breath for any improvements.

@tylerszabo
Copy link

@MarkCallow have you tried using the ext+container:name=Profile1&url=https://www.example.com/ ext+container:name=Profile2&url=https://www.example.com/ - it's not ideal but it does allow you to have bookmarks for the same URL and have them open in different containers and that can be used to manage multiple logged-in accounts for services that don't natively support that.

Selecting "always open in container" will override the bookmark, though (which makes sense for "always"). I don't know if there's a way to have a "default to this container" but I think that would be a separate issue.

It would be nice to have bookmarks support containers directly and not need to use the ext+container: scheme.

@grahamperrin
Copy link

#323 (comment)

multiple account logins within a single domain

For this, I use a complementary extension. See #854 (comment)

@grahamperrin
Copy link

grahamperrin commented Dec 27, 2020

#323 (comment)

Open bookmark into Container

This (the subject line) is, essentially, resolved as pictured at #323 (comment)

Open Bookmark in Container Tab ▶ …

Continuing to discuss #854 under #323 serves no useful purpose; people can simply discuss #854 under #854

Given the resolution, I respectfully suggest closing this issue. Thanks

@MichaelTunnell
Copy link

MichaelTunnell commented Dec 27, 2020

@grahamperrin

Given the resolution, I respectfully suggest closing this issue. Thanks

I respectfully disagree and so does the original poster of this issue. The effort to make #854 to be accepted as an issue took 3 years for no reason because maintainers repeatedly closed it as a duplicate of this issue because they refused to listen to why it was different. Now that it is acknowledged that it is a different issue this issue should only be closed when #854 is due to the 3 year delay they forced on it.

If you want more info as to why here is a much longer version of the explanation: issuecomment-667159313

edit: now that I think about it, @gwynnarth would you mind editing your original issue post to include a link for #854 so people who are interested in that feature can quickly find it for discussion?

@grahamperrin
Copy link

Focusing on the technical:

@wsdfhjxc
Copy link

wsdfhjxc commented Jan 5, 2021

This isn't so trivial to implement, as from a quick look at the extensions API, it seems that although there is a way to determine whether a URL transition event comes from opening a bookmark, there seems not to be a way to retrieve further information about the bookmark itself (not even ID). The only carried information, that can be universally matched against the container mapping rules, is the URL for the transition. Please correct me if I'm mistaken. Because otherwise, the extension could just have an additional, customizable list of bookmark IDs per each container, and keep track of them, like it does for websites and their URLs.

Anyway, for those who don't want to scan the whole thread for a workaround, I'm reminding about the one that utilizes a protocol handler method provided by the Open external links in a container extension. The downside is that the URLs of bookmarks are modified (special format), which results in broken favicons. Other than that, it's a very clever way to achieve the desired behavior.

@grahamperrin
Copy link

This isn't so trivial to implement,

It's implemented. Did you post to the wrong issue?

@wsdfhjxc
Copy link

wsdfhjxc commented Jan 6, 2021

Only the context menu part is implemented. Quoting OP:

[...] might be even more useful if user could associate a particular bookmark with a particular Container so that it automatically opens in the right Container [...]

And then the big chunk of the thread basically revolves around that idea. It's not implemented. If the scope of this issue was only about the context menu, the issue should have been closed long time ago, and yet it isn't. The thread is still open, and active supporters of the idea don't even want it to be closed, until said automatic feature is implemented.

You're right that there is an another issue with a more specific title, so my post could fit better there. However, I'll dare to say, that doesn't make it invalid here, given all of the above. If what you're after is that there should be no more noise in this particular thread, then okay, I'm sorry for that, and I won't post here again. But really, in such case, keeping this issue open doesn't help anyone...

@caltheon
Copy link

caltheon commented Jan 6, 2021

If the issue is the bookmark handler cannot support the functionality requested, and I assume getting that changed is probably a non-starter, would it make sense to change this to a feature request to add bookmarks to the container plugin itself to bypass the issue?

@grahamperrin
Copy link

the context menu part

That was this issue, which is implemented.

#854 is relevant to what's not implemented.

@dannycolin dannycolin added 👍 Feature Request Feature requests users would like to see in this addon and removed enhancement labels May 20, 2022
@dannycolin dannycolin changed the title Open bookmark into Container Assign bookmark to Container Jun 14, 2022
@dannycolin dannycolin added the Needs: Mozilla Central Needs changes in Mozilla-Central label Jun 14, 2022
@historytimeline
Copy link

This would be very useful to me. It would allow to open a bookmark directly to a specific container. Further, it would allow to assign the same website to different containers, using different bookmarks, then open them with no extra clicks needed. When you need multiple bookmarked containers for the same website (as I do need), this bypasses the problem "open always in container" , which effectively blocks using multiple containers in the same website.

@dannycolin dannycolin added the Status: Moved Issues moved to another platform (Bugzilla, Connect, etc). label Jan 2, 2023
@dannycolin
Copy link
Collaborator

Hey all,

I'm moving this feature request to our new feedback platform Mozilla Connect
so it gets more visibility.

On this platform if an idea has received a great deal of support (votes, comments)
it will be tagged as "Trending Idea" and the Mozilla team is going review it for
potential adoption.

Please upvote and comment on the following idea:

https://connect.mozilla.org/t5/ideas/container-preference-in-bookmarks/idi-p/3857

@mozilla mozilla locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Context Menu Issues related to menu items in Firefox context menu Needs: Mozilla Central Needs changes in Mozilla-Central Status: Moved Issues moved to another platform (Bugzilla, Connect, etc). 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Development

No branches or pull requests