Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement full keyboard functionality #512

Open
4 tasks
jonathanKingston opened this issue May 16, 2017 · 5 comments
Open
4 tasks

Implement full keyboard functionality #512

jonathanKingston opened this issue May 16, 2017 · 5 comments
Labels
Component: Shortcuts Issues related to keyboard shortcuts 👍 Feature Request Feature requests users would like to see in this addon

Comments

@jonathanKingston
Copy link
Contributor

#509 will add the ability for users to open the browser action however it doesn't add functionality to all screens.

@groovecoder agreed this can be a followup as it's likely to be a big one we perhaps could do in chunks.

The notable things that don't work are:

  • Down, up arrows not on edit screen
  • Tab key doesn't work in the panel for editing containers and making new containers?
  • Right, Left doesn't work on entering the container right arrow, leaving it
  • Down, up arrows on selecting existing tabs in the container view
@jk3us
Copy link

jk3us commented Nov 21, 2017

I don't know if this is the right place, but I'd like to see keyboard shortcuts for things like cycling through containers with open tabs (and hiding all the others), and toggling between viewing "only container of current tab" and everything. This would give it some of the usefulness of the old tab groups. Both of these are extensions of the existing show/hide container functionality.

@groovecoder groovecoder added enhancement and removed bug Something is broken! labels Dec 5, 2017
@ShivangiKakkar
Copy link
Contributor

@jonathanKingston @groovecoder Regarding the things/shortcuts that you have pointed out above, I tried implementing some(not all) of them, should I go ahead and create a PR? Thanks. 🙂

@jonathanKingston
Copy link
Contributor Author

@ShivangiKakkar Yeah totally, smaller PRs are always easier to merge!

@yellowwoods12
Copy link

Hi @groovecoder, @maxxcrawford and @jonathanKingston, I would like to work on this one. Can you please assign it to me?

@HagarMostafa
Copy link

Hello @groovecoder, @maxxcrawford, can you assign this issue to me if it is not already assigned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Shortcuts Issues related to keyboard shortcuts 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Development

No branches or pull requests

7 participants