-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context popup for containers when creating a tab (particularly via keyboard shortcut) #544
Comments
As of this week, there's a keyboard shortcut to open the pop-up, and to tab down to a container. So the steps are:
|
We have not announced this feature yet as if you have a text field focussed this doesn't work. This includes the URL bar too. I'm looking into ways we can expose this more. Adding numbers for keyboard navigation is certainly something we can do for #512. |
I have also raised #546 to move this to Ctrl+Comma as it has URL bar issues. |
@groovecoder @jonathanKingston thanks for the update! the only disadvantage of and tabbing to select in a dropdown list is not as intuitive (to me) as either (1) using arrow keys or (2) choosing numbers, but if that's the implementation, then i can live with it. in any case, focusing on the url bar afterwards is definitely key (pun intended) to an efficient keyboard-based workflow. 😊 |
@clairity focusing the URL bar will come back (this is available in Nightly and I think Beta), we are not sure about the keyboard shortcut alternative as of yet. |
More than numbers or Tab, I would expected to select the container type with the arrow keys. You can use the arrow keys after the first Tab, but not till after that. |
Currently, I can only use It would be nice if it was |
This commit adds functionality that will try to open new tabs in the same container as the previously active tab in that window, if the new tab doesn't already have a container, and the previously active tab did. Some undocumented / implicity functionality in the webextension API is used: * `onCreated` is called for a new tab before `onActivated` for that tab is called * `onUpdated` will be called for all new tabs, also `about:newtab` and the like (sets the favicon) * The first `onUpdated` for a new tab, that is not an `about:`-tab, will set the URL It is a little bit wonky, as the original new tab is created and displayed (although not loaded) before it can be closed a new tab can be created. However, it is the best workaround I can find to add this functionality until Bugzilla 1406371 is solved. This would fix mozilla#462, mozilla#448 and mozilla#406 (I think) Also relates to mozilla#943 and mozilla#544
this is somewhat related to #245, #311, and #518. i'd love cmd-t (and equivalents on other OSes) to provide a context menu to choose the container type to open. so
cmd-t
to signal the desire for a new tab1
for a Personal container)this might need a configuration setting for how
cmd-t
behaves since some people may not want the extra context menu, or this flow can be triggered by a more complicated keyboard shortcut (likectrl-cmd-t
on mac).this context menu also could be used when cmd-/ctrl-clicking links or converting tabs from one type of container to another (selectable via keyboard number, click or touch, and possibly auto-hiding after a couple seconds or via
esc
).┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: