Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox for "Remember my decision for this site" is not in line with the text #607

Closed
Softvision-VladBacia opened this issue Jun 21, 2017 · 2 comments
Assignees
Labels
bug Something is broken! Component: Site Assignment Issues related to assigning a site to a container

Comments

@Softvision-VladBacia
Copy link

[Affected versions]:

  • Firefox 54
  • Containers Experiment Build: 2.3.0

[Affected Platforms]:

  • All Windows
  • All Linux
  • All Mac

[Prerequisites]:

  • Containers Experiment is installed on a new browser profile.
  • A webpage (www.reddit.com) is saved in a custom container.

[Steps to reproduce]:

  1. Start the browser with the profile from prerequisites and open a normal New Tab.
  2. Write the name of the saved webpage amd press "Enter".
  3. Observe the "Remember my decision for this site" area

[Expected results]:

  • The text "Remember my decision for this site" is in line with the checkbox.

[Actual results]:

  • The checkbox is positioned slightly upper than the text.

[Notes]:

  • Attached a screenshot of the issue:
    checkbox is not in line with the text
@kjozwiak
Copy link

Minor UI issue but we should get this fixed before launching the shield study as the Always Open in This Container feature is pretty integral to the container experience.

Reproducible on the latest fx54, fx55.0b4 and fx56.0a1 builds.

@jonathanKingston, mind taking a look? Should be trivial to fix.

@kjozwiak kjozwiak added Component: Site Assignment Issues related to assigning a site to a container bug Something is broken! shield labels Jun 21, 2017
@kjozwiak kjozwiak added this to the Start Shield Study milestone Jun 21, 2017
@kjozwiak kjozwiak added the Low label Jun 21, 2017
jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Jun 22, 2017
groovecoder added a commit that referenced this issue Jun 22, 2017
…nment

Fixing alignment of checkbox on confirm screen. Fixes #607
@Softvision-VladBacia
Copy link
Author

This issue was verified on Firefox latest release v54.0 with Containers Experiment v2.4.0 and it cannot be reproduced. Thus, marking this issue as Verified-Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Component: Site Assignment Issues related to assigning a site to a container
Projects
None yet
Development

No branches or pull requests

3 participants