Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording - automatically add sites to containers as you browse #1613

Closed
wants to merge 9 commits into from

Conversation

mckenfra
Copy link
Contributor

Currently it's impossible to add an assignment if the URL immediately redirects. E.g. if you enter google.com in the address bar, it will immediately redirect to www.google.com. If you then open the MAC popup and click on Always open in ..., the assignment for www.google.com will be created, but not for google.com.

This pull request adds the ability to record assignments automatically as you browse. So in the example above, it will automatically add both google.com and www.google.com. See screencast below.

This pull request also improves the MAC messages that popup over your browser window, e.g. when you click Always open in .... Previously the messages sometimes were mis-positioned or did not appear. Now the messages appear correctly, and multiple simultaneous messages stack with a smooth animation. See screencast below.

Unit tests included.

MAC

@mckenfra mckenfra force-pushed the recording branch 9 times, most recently from abed1e9 to 203aa9f Compare January 15, 2020 00:40
@jonathanKingston
Copy link
Contributor

jonathanKingston commented Jan 21, 2020

@TanviHacks I really think this is a pretty cool feature. How are we handling new features like this now? Do they have to go through design?
I'm happy to code review if we want to merge this.
Perhaps the better solution is provide the correct APIs so another extension can do this instead and MAC becomes and extension point itself?

@alchen alchen mentioned this pull request Jul 22, 2021
@dannycolin
Copy link
Collaborator

Closing in favor of implementing an API to manage website assignments in Firefox itself.

@dannycolin dannycolin closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants