Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to edit websites that open automatically in a certain container #1627

Closed
wants to merge 3 commits into from

Conversation

anirudhb
Copy link

@anirudhb anirudhb commented Feb 1, 2020

Changes

  • "Sites assigned to open in this container" is always visible, even if there are no sites assigned. However, this does not show when creating a new container.
  • Added "+" icon on the side of the title, which creates a new input to add a website.

Behavior

If the user types the URL "cnn.com", https:// is added, but not www
If the user types the URL "http://cnn.com", nothing is added
If the user types the URL "www.cnn.com", https:// is added, but not www
If the user types the URL "https://cnn.com", nothing is added

This was created out of personal need, but I feel that it could be useful to everyone to have. This is especially useful when the URL you want to add instantly redirects to another URL when it is typed in the omnibox (which you cannot do with the checkbox currently.)

I notice that #1613 also implements similar features, but takes a different approach. This is easier for power users because you do not have to open the website in the container.

@dannycolin
Copy link
Collaborator

First of all, thank you for your contribution. Unfortunately, I'll have to close this issue as it needs to be thoughtfully planned before working on the code. By this, I mean that there's UX/design decisions that needs to be discussed and made.

On top of that, there's some early discussion to move the site assignments feature in Multi-Account Containers to a separated WebExtension API. Depending on the outcome, it could drastically change our approach on the implementation of this feature. When I have more information on this, I'll make an announcement on your Matrix room at https://matrix.to/#/#containers:mozilla.org.

@dannycolin dannycolin closed this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants