Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable proxyDNS only for supported proxies (SOCKS4/5) #2333

Merged
merged 2 commits into from
Apr 25, 2022
Merged

enable proxyDNS only for supported proxies (SOCKS4/5) #2333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ef50dd
enable proxyDNS only for supported proxies (SOCKS4/5)
eladyn Apr 19, 2022
0b869a1
improve proxy type matching
eladyn Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/js/background/assignManager.js
View file
Open in desktop
Expand Up @@ -197,12 +197,17 @@ window.assignManager = {
return {};
}

// proxyDNS only works for SOCKS proxies
if (["socks", "socks4"].includes(result.proxy.type)) {
result.proxy.proxyDNS = true;
}

if (!result.proxy.mozProxyEnabled) {
return { ...result.proxy, proxyDNS: true };
return result.proxy;
}

// Let's add the isolation key.
return [{ ...result.proxy, connectionIsolationKey: "" + MozillaVPN_Background.isolationKey, proxyDNS: true }];
return [{ ...result.proxy, connectionIsolationKey: "" + MozillaVPN_Background.isolationKey }];
},

// Before a request is handled by the browser we decide if we should
Expand Down