enable proxyDNS only for supported proxies (SOCKS4/5) #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladyn
force-pushed
the
proxy_proxyDNS_fix
branch
from
4d29a19
to
0ef50dd
Compare
nekno
reviewed
Apr 20, 2022
nekno
approved these changes
Apr 20, 2022
Co-authored-by: nekno <nekno@users.noreply.github.com>
bakulf
approved these changes
Apr 25, 2022
|
Hi Folks... any idea when this will land on the firefox addons page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/ProxyInfo:
This only enables
proxyDNS, if the proxy type is asocksorsocks4proxy, because setting it on other types caused the whole proxy setting to be ignored.Fixes #2278 (at least for me, confirmations appreciated)
Tesing instructions
mitmproxy.http://localhost:8080as proxy.If you can see this, traffic is not passing through mitmproxy.mitmproxy.