Fix #2168 Use a different l10n string for sites opened in no container #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
requested changes
Jul 27, 2022
groovecoder
approved these changes
Aug 1, 2022
2 tasks
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Aug 8, 2022
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Aug 8, 2022
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Aug 8, 2022
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Aug 8, 2022
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Aug 8, 2022
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Aug 8, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you assign a website to the Personal container and open the same website in the Work container, it will show you a confirmation page where the left button shows "Open in Work Container".
However, if the current tab in which you open the website isn't a container, it will show "Open in Container" because the code returns a null value for the container name.
This patch fixes this by showing a different message for this situation by adding a new l10n string (openInNoContainer).