Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version bump package json #2460

Merged
merged 3 commits into from Nov 29, 2022
Merged

version bump package json #2460

merged 3 commits into from Nov 29, 2022

Conversation

maxxcrawford
Copy link
Collaborator

@maxxcrawford maxxcrawford commented Nov 29, 2022

  • Add package-lock.json to tracked files
  • Bump version number to 8.1.1

Developer note: when installing via $ npm install, I get a ERESOLVE overriding peer dependency error.

ERESOLVE overriding peer dependency
While resolving: webextensions-api-fake@1.3.0
Found: sinon@7.5.0
node_modules/sinon
  dev sinon@"^7.5.0" from the root project
  2 more (sinon-chai, webextensions-api-mock)

Could not resolve dependency:
peer sinon@"^8.1.1" from webextensions-api-fake@1.3.0
node_modules/webextensions-api-fake
  webextensions-api-fake@"^1.2.0" from webextensions-jsdom@1.4.1
  node_modules/webextensions-jsdom

Conflicting peer dependency: sinon@8.1.1
node_modules/sinon
  peer sinon@"^8.1.1" from webextensions-api-fake@1.3.0
  node_modules/webextensions-api-fake
    webextensions-api-fake@"^1.2.0" from webextensions-jsdom@1.4.1
    node_modules/webextensions-jsdom

I was able to resolve by running $ npm install --legacy-peer-deps.

@maxxcrawford maxxcrawford marked this pull request as ready for review November 29, 2022 16:12
@dannycolin dannycolin merged commit 6594a06 into main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants