Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox Accounts Rebrand (Dot Release) #2591

Merged
merged 5 commits into from Oct 24, 2023
Merged

Firefox Accounts Rebrand (Dot Release) #2591

merged 5 commits into from Oct 24, 2023

Conversation

maxxcrawford
Copy link
Collaborator

@maxxcrawford maxxcrawford commented Oct 24, 2023 •
edited

  • FXA Rebrand 6046625
  • Bump version number to 8.1.3

Testing steps: (See screenshots for more context)

  • Run add-on
  • Open panel (Go through onboarding)
  • Expected: On Syncing panel (Panel 6), there should be no mention of "Firefox"
  • Click "Start Syncing"
  • Expected: On this panel, there should be no mention of "Firefox"
  • Close Panel
  • Open MAC Settings page (in about:addons)
  • Expected: The Synchronization section should not mention "Firefox"

Screenshots

image image image

@maxxcrawford maxxcrawford changed the title 8.1.3 candidate Firefox Accounts Rebrand (Dot Release) Oct 24, 2023
@maxxcrawford maxxcrawford marked this pull request as ready for review October 24, 2023 18:32
dannycolin
dannycolin approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@dannycolin dannycolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@maxxcrawford maxxcrawford merged commit 8ace15f into 8.1.3-release Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycolin dannycolin dannycolin approved these changes

@groovecoder groovecoder Awaiting requested review from groovecoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxxcrawford @dannycolin