for #20: start onboarding UI in pop-up #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
commented
Jan 3, 2017
| @@ -40,6 +40,33 @@ function showContainerTabs(containerId) { | |||
| hideorshowIcon.src = CONTAINER_HIDE_SRC; | |||
| } | |||
|
|
|||
| if (localStorage.getItem('onboarded2')) { | |||
There was a problem hiding this comment.
@jonathanKingston - I'm really not happy with this logic for controlling the shown/hidden state of the onboarding vs. container panels. I'll keep poking at this code to improve it.
|
@TanviHacks do you mean each of those elements needs its own onboarding tutorial/panel? |
|
Deleted extra comments. Assigning to @jonathanKingston for review & spot-check. Note: This depends on us having Firefox 52 ContextualIdentityService module, so we need to get that sorted. |
groovecoder
force-pushed
the
container-onboarding-20
branch
from
fdf5c95
to
8eb52c7
Compare
|
Rebased this branch on @bakulf and @jonathanKingston's latest commits in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress; still needs: