2.0.0 to production

[groovecoder]

Includes fix where upgrading the add-on accidentally destroys custom containers. Note: the 2.0.0 upgrade will still destroy custom containers, because the bug is in the 1.x add-on "uninstall" code that users already have. 😢 But, 2.0.0+ upgrade should preserve all custom containers.

Also includes improved sanitizing of container names.

[groovecoder]

To check the upgrade, here's what I do:

1. git checkout a previous version commit. (e.g., 502177e for 1.0.4, or d9065b5 for 1.1.1)
2. jpm xpi to build the add-on at that version
3. Go to about:addons and install the testpilot-containers.xpi built in step 2
4. Create a custom container, and open some tabs in it
5. git checkout this branch (i.e., 2.0.0)
6. jpm xpi to build the 2.0.0 testpilot-containers.xpi add-on
7. Go to about:addons and install the 2.0.0 testpilot-containers.xpi built in step 6
   • You will lose the custom container you created in step 4 😢
8. Create another custom container (now in 2.0.0), and open some tabs in it
9. Set the version to 2.0.1 in package.json
10. jpm xpi to build the 2.0.1 testpilot-containers.xpi add-on
11. Go to about:addons and install the 2.0.1 testpilot-containers.xpi built in step 10
    • You will NOT lose the custom container you created in step 8 🎉

[kjozwiak]

Test Case 1 (1.0.4 -> 2.0.0 -> 2.0.1):

• Created several custom containers and opened/logged into several websites using 1.0.4
• Updated 1.0.4 -> 2.0.0 (lost all custom containers, custom container cookies removed from cookies.sqlite)
• Created several custom containers and opened/logged into several websites using 2.0.0
• Updated 2.0.0 -> 2.0.1 (didn't lose any custom containers.. checked cookies.sqlite and didn't lose any cookies and stayed logged in)

Test Case 2 (1.1.1 -> 2.0.0 -> 2.0.1):

• Created several custom containers and opened/logged into several websites using 1.1.1
• Updated 1.1.1 -> 2.0.0 (lost all custom containers, custom container cookies removed from cookies.sqlite)
• Created several custom containers and opened/logged into several websites using 2.0.0
• Updated 2.0.0 -> 2.0.1 (didn't lose any custom containers.. checked cookies.sqlite and didn't lose any cookies and stayed logged in)