Open new tabs in same container as previous tab #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds functionality that will try to open new tabs in the same container as the previously active tab in that window, if the new tab doesn't already have a container, and the previously active tab did. Some undocumented / implicity functionality in the webextension API is used: * `onCreated` is called for a new tab before `onActivated` for that tab is called * `onUpdated` will be called for all new tabs, also `about:newtab` and the like (sets the favicon) * The first `onUpdated` for a new tab, that is not an `about:`-tab, will set the URL It is a little bit wonky, as the original new tab is created and displayed (although not loaded) before it can be closed a new tab can be created. However, it is the best workaround I can find to add this functionality until Bugzilla 1406371 is solved. This would fix mozilla#462, mozilla#448 and mozilla#406 (I think) Also relates to mozilla#943 and mozilla#544
tlaundal
added a commit
to tlaundal/multi-account-containers
that referenced
this pull request
Nov 21, 2017
|
Thanks for the PR ! Hope it'll be reviewed merged, and deployed on store soon. |
|
Also relates to #1000 |
|
Thanks for the PR! |
|
Been a year - the platform bug never landed AFAICT. Could this PR get revived? I would really like functionality similar to the "sticky containers" extension (which I would use if it wasn't so buggy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality that will try to open new tabs in the same container as the previously active tab in that window, if the new tab doesn't already have a container, and the previously active tab did.
Some undocumented / implicity functionality in the webextension API is used:
onCreatedis called for a new tab beforeonActivatedfor that tab is calledonUpdatedwill be called for all new tabs, alsoabout:newtaband the like (sets the favicon)onUpdatedfor a new tab, that is not anabout:-tab, will set the URLIt is a little bit wonky, as the original new tab is created and displayed (although not loaded) before it can be closed and a new tab can be created. However, it is the best workaround I can find to add this functionality until Bugzilla 1406371 is solved.
This would fix #462, #448 and #406 (I think)
Also relates to #943 and #544