-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idle_timeout_crazy_rtt can timeout if there are two losses #974
Comments
OK, analysis is that this is the result of a rare double-loss of packets containing HANDSHAKE_DONE. Nothing serious here; we expect that to happen because this test is badly exposed to loss as the idle timeout ends up being set to 3PTO. Now, we've discussed sending more aggressively on PTO (by making the first PTO happen at half the nominal time), which might help fix this. Until we have something more stable, I'll keep this open. |
98c5c815e436f9adc043bd0509f752ee967f0502526b6acf1880fc312f0206ce |
It took longer to get a failure, but here is another one: ecebadd179ce347280ffcd3e62b5037745f5b588017dace25007bb6914f9d56d |
This is happening frequently enough in CI that we should really fix this. |
I am unable to reproduce this failure locally, neither randomly running in a loop ( Any additional pointers, e.g. CI failure links, ... Local machine:
|
IIRC the CI failures are always on Windows. |
This doesn't seem to happen anymore. |
Run:
Fixing this might require some work.
The text was updated successfully, but these errors were encountered: