Added spaces between extensions when copying the list of extensions #195
Conversation
…ns to the Clipboard When the list of extensions is copied to the Clipboard and pasted on a location where newlines are not allowed, the extensions get glued together: Firebug 3.0.0-alpha.14Utilu Nightly Tester Tools 3.7.1.1Web Developer 1.2.7 After this change there is a space between the extensions: Firebug 3.0.0-alpha.14 Utilu Nightly Tester Tools 3.7.1.1 Web Developer 1.2.7
|
@whimboo Please review and merge. |
|
Do you actually have an example where that happens? If new lines are not allowed they should at least replaced by a space. |
|
It happens even in Firefox itself, try pasting the list of extensions in for example the address bar or the search bar. The newlines are removed, not replaced by spaces. This also happens in for example File Explorer. |
|
@whimboo Do you need more examples? |
|
Maybe replace the newlines by commas instead? Or replace NL by comma+space? I see there are spaces in the names of most extensions, and spaces vs. spaces might be confusing. |
| @@ -361,7 +361,7 @@ getExtensionList: function(callback) { | |||
| + (addon.userDisabled || addon.appDisabled ? " [DISABLED]" : ""); | |||
| }); | |||
| strings.sort(nightly.insensitiveSort); | |||
| callback(strings.join("\n")); | |||
| callback(strings.join(" \n")); | |||
| }); | |||
| } catch(e) { | |||
| // old extension manager API - take out after Firefox 3.6 support dropped | |||
There was a problem hiding this comment.
Not relevant to this PR but we should get a new issue created so the old API can finally be removed.
| @@ -361,7 +361,7 @@ getExtensionList: function(callback) { | |||
| + (addon.userDisabled || addon.appDisabled ? " [DISABLED]" : ""); | |||
| }); | |||
| strings.sort(nightly.insensitiveSort); | |||
| callback(strings.join("\n")); | |||
| callback(strings.join(", ")); | |||
There was a problem hiding this comment.
What you want is to not to call strings.join() here but pass over the array as parameter into the callback. So inside the callback you join the strings then.
There was a problem hiding this comment.
As said you want to call callback(strings) and do the call to join() where the strings get printed. Sorry but I don't have the time to do any actual work on NTT beside reviews.
|
@UtiluMark do you have an update for us? Would be nice to get this PR finished and merged. Thanks. |
|
@whimboo I don't know what to change exactly. Could you finish and merge this PR? |
|
@xabolcs Please check. Thanks. |
|
@UtiluMark, thanks for the update. Will review it later. There is at least two not yet addressed topic here:
|
I think that this is perfectly covered via issue #161 already. So please skip this comment.
Same here. This was just an idea. I don't see it to be necessary for this PR. |
|
@UtiluMark, it looks good to me:
Thanks! @whimboo, about that separator idea, could you file an issue? I have ideas too for improvement. :) |
I thought more about it and I think that we can do that if there is a demand for it. I don't think we should overload the extension by making too much configurable. We should first make sure to get all services working again. If you think it is very useful with your idea, feel free to file the issue. |
|
First, I did not expect that I would have to look under Pull Requests for this issue. The problem is that by making this change, adding a comma between extensions, it means that if you paste into an Excel spreadsheet or a Word document, the list of extensions go into one cell or one paragraph, respectively. Also, if you paste (or insert) into text boxes like this one, you get a "paragraph" as it appears in @xabolcs' comment of Aug 22 just above. When you have a good number of extensions installed, it is harder to read through a "jumble" like that compared to a "list" of 1 extension per line like mine from my work computer: about:addons-memory 2016 10.0.1 I am wondering. What is the outlier case here? Is it mine where, prior to this change, you get a list that works well for Excel, Word, and in text boxes on web pages or @UtiluMark's which I am not even sure where it occurs aside, perhaps, if someone is pasting to Notepad. Might I suggest that the user be offered the option of how they want the list to be provided. The old way where, for many apps, a list is produced and, for users like @UtiluMark, the list with commas after each extension? |
|
@WildcatRay thank you for the comment! And sorry that I haven't had the time yet to get all this updated in our issue tracker. So thank you for the reminder. I filed two more issues where we can track necessary work. Reverting to use new lines should be shipped with the next release, whereby making the separator selectable has no ETA yet. With that plan I hope we can fix everyones expectations. |
|
Thank you and your welcome, @whimboo. |
|
@WildcatRay @whimboo PR #232 should fix this. |
When the list of extensions is copied to the Clipboard and pasted on a
location where newlines are not allowed, the extensions get glued
together:
Firebug 3.0.0-alpha.14Utilu Nightly Tester Tools 3.7.1.1Web Developer
1.2.7
After this change there is a space between the extensions:
Firebug 3.0.0-alpha.14 Utilu Nightly Tester Tools 3.7.1.1 Web Developer
1.2.7
Part of #188