-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Services.jsm #6
Conversation
Conflicts: components/nttAddonCompatibilityService.js
I'm about to clean-up old pull requests now. So thanks for the patch Erik! The patch looks good but there is one more change you will have to make. Our minVersion for each application is still 3.6 (mozilla-1.9.2). Given that Services.jsm has been introduced with mozilla-2.0 we have to bump the minVersion entries. I would propose to use 4.0. |
Please don't drop gecko 1.9.x support! If |
Well, we can at least wait until we officially have no longer nightly builds on mozilla-1.9.2. Mozilla will discontinue support for Firefox 3.6 in April. So I don't think it's worth to still supporting Firefox 3.6 at this stage any longer. Users of the extension could install an older version of it if it's really necessary. |
Latest Songbird nightly is still gecko 1.9.x based. Would You like drop Songbird support too? A wrapper module would be acceptable after these commits, to support old gecko again? |
Someone should get in contact with the Songbird developers and ask them what's the process to get xulrunner upgraded to a more recent version. Probably they were waiting for the first ESR release? Would you mind doing it? |
I'd prefer to write that wrapper module rather than contacting them, at first sight. :) |
can we just pull a copy of |
Erik, sounds like a good proposal. How many different files in the repository would benefit from it? If it's worth we should add it and update any Cc/Cc call to use the available entry from Services.jsm instead. Could make our code way cleaner. |
I think that this can wait until 3.2.3. |
Moving to 3.4 because it's not that necessary to get out to our user base. |
Clearing milestone |
With the WebExtension API rewrite this is now fixed. 👍 |
No description provided.