Using Services.jsm #6

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

No description provided.

Contributor

whimboo commented Mar 1, 2012

I'm about to clean-up old pull requests now. So thanks for the patch Erik! The patch looks good but there is one more change you will have to make. Our minVersion for each application is still 3.6 (mozilla-1.9.2). Given that Services.jsm has been introduced with mozilla-2.0 we have to bump the minVersion entries. I would propose to use 4.0.

Collaborator

xabolcs commented Mar 1, 2012

Please don't drop gecko 1.9.x support!
Some times ago there were commits to reintroduce the support of gecko 1.9.x: ea737c6, 5afd1bb

If Services.jsm is needed, then it could be borrowed from mxr! See http://mike.kaply.com/2011/02/08/adding-services-to-your-firefox-add-on/

Contributor

whimboo commented Mar 1, 2012

Well, we can at least wait until we officially have no longer nightly builds on mozilla-1.9.2. Mozilla will discontinue support for Firefox 3.6 in April. So I don't think it's worth to still supporting Firefox 3.6 at this stage any longer. Users of the extension could install an older version of it if it's really necessary.

Collaborator

xabolcs commented Mar 1, 2012

Latest Songbird nightly is still gecko 1.9.x based. Would You like drop Songbird support too?

A wrapper module would be acceptable after these commits, to support old gecko again?

Contributor

whimboo commented Mar 2, 2012

Someone should get in contact with the Songbird developers and ask them what's the process to get xulrunner upgraded to a more recent version. Probably they were waiting for the first ESR release? Would you mind doing it?

Collaborator

xabolcs commented Mar 2, 2012

I'd prefer to write that wrapper module rather than contacting them, at first sight. :)

erikvold commented Mar 2, 2012

can we just pull a copy of Services.jsm in to the repo until we can remove it?

Contributor

whimboo commented Mar 5, 2012

Erik, sounds like a good proposal. How many different files in the repository would benefit from it? If it's worth we should add it and update any Cc/Cc call to use the available entry from Services.jsm instead. Could make our code way cleaner.

Contributor

whimboo commented Mar 14, 2012

I think that this can wait until 3.2.3.

Contributor

whimboo commented May 2, 2012

Moving to 3.4 because it's not that necessary to get out to our user base.

Collaborator

xabolcs commented Mar 13, 2013

Clearing milestone 3.5.

Collaborator

xabolcs commented Oct 11, 2017

With the WebExtension API rewrite this is now fixed. 👍

@xabolcs xabolcs closed this Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment