Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include about:nightly in Nightly Tester Tools' menupopup in messengerOverlay.xul. Fixes #56. #76

Closed
wants to merge 2 commits into from
Closed

Include about:nightly in Nightly Tester Tools' menupopup in messengerOverlay.xul. Fixes #56. #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814b299
Issue #56 - include about:nightly in the nightly-menu.
xabolcs May 29, 2012
790ff8d
Addressed comment:
xabolcs Jun 15, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions extension/chrome/content/messenger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},

openAboutNightly: function() {
var tabmail = document.getElementById("tabmail");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add a blank between function and the opening bracket.

tabmail.openTab("contentTab",
{ contentPage: "about:nightly" }
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a single line? It should be less than 80 characters.

},

}
2 changes: 2 additions & 0 deletions extension/chrome/content/messengerOverlay.xul
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
<menupopup id="taskPopup">
<menu id="nightly-menu" label="Nightly Tester Tools" insertafter="devToolsSeparator">
<menupopup onpopupshowing="nightly.menuPopup(event,this);">
<menuitem label="&nightly.openabout.label;" oncommand="nightlyApp.openAboutNightly();"/>
<menuseparator/>
<menuitem id="nightly-build-copy" label="&nightly.id.copy.label;" oncommand="nightly.copyTemplate('buildid');"/>
<menuitem id="nightly-build-insert" label="&nightly.id.insert.label;" oncommand="nightly.insertTemplate('buildid');"/>
<menuitem id="nightly-list-copy" label="&nightly.extensions.copy.label;" oncommand="nightly.copyExtensions();"/>
Expand Down
1 change: 1 addition & 0 deletions extension/chrome/locale/en-US/nightly.dtd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!ENTITY nightly.openabout.label "Open about:nightly">
<!ENTITY nightly.openprofile.label "Open Profile Folder">

<!ENTITY nightly.id.copy.label "Copy Build ID to Clipboard">
Expand Down