Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Include about:nightly in Nightly Tester Tools' menupopup in messengerOverlay.xul. Fixes #56. #76

Closed
wants to merge 2 commits into from

2 participants

Szabolcs Hubai Henrik Skupin
Szabolcs Hubai
Owner

Hi!

This is a trivial fix, "based" on @protz work.

Feel free to review it!

extension/chrome/content/messenger.js
@@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},
+openAboutNightly: function() {
+ document.getElementById("tabmail")
+ .openTab("contentTab",
Henrik Skupin Owner
whimboo added a note

For better readability I would prefer a temporary variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Henrik Skupin
Owner

hm, while thinking a bit more about this request I wonder why we need this. What is included in about:nightly that users have to open it via a menuitem in the main menu? I don't see any functionality in it which would qualify for such a menu item.

Szabolcs Hubai
Owner

whimboo wrote:

... have to open via a menuitem in the main menu? ...

Pull request was renamed to Include about:nightly in the nightly-menu Nightly Tester Tools' menupopup in messengerOverlay.xul. Fixes #56.

Szabolcs Hubai
Owner

Commit updated: temporary variable for "tabmail".

extension/chrome/content/messenger.js
@@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},
+openAboutNightly: function() {
+ var tabmail = document.getElementById("tabmail");
Henrik Skupin Owner
whimboo added a note

nit: please add a blank between function and the opening bracket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
extension/chrome/content/messenger.js
@@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},
+openAboutNightly: function() {
+ var tabmail = document.getElementById("tabmail");
+ tabmail.openTab("contentTab",
+ { contentPage: "about:nightly" }
+ );
Henrik Skupin Owner
whimboo added a note

Why not a single line? It should be less than 80 characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Szabolcs Hubai xabolcs Addressed comment:
- space between
- single line
790ff8d
Szabolcs Hubai
Owner

Adressed comments:

  • a space between function and (
  • single line the tabmail.openTab() stuff

Would You mind to let me fold the changes into one commit after r+?
Thanks!

Henrik Skupin
Owner

Looks great and I will land it now.

Would You mind to let me fold the changes into one commit after r+?

I will do a merge --squash which will combine all of your commits into a single one on master.

Henrik Skupin whimboo referenced this pull request from a commit
Henrik Skupin whimboo Revert "Include about:nightly in Nightly Tester Tools' menupopup for …
…Thunderbird (#76)"

This reverts commit a31e8ab.
7650792
Henrik Skupin
Owner

Pushed:
80cd149

Henrik Skupin whimboo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 29, 2012
  1. Szabolcs Hubai
Commits on Jun 15, 2012
  1. Szabolcs Hubai

    Addressed comment:

    xabolcs authored
    - space between
    - single line
This page is out of date. Refresh to see the latest.
5 extension/chrome/content/messenger.js
View
@@ -127,4 +127,9 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},
+openAboutNightly: function () {
+ var tabmail = document.getElementById("tabmail");
+ tabmail.openTab("contentTab", { contentPage: "about:nightly" });
+},
+
}
2  extension/chrome/content/messengerOverlay.xul
View
@@ -61,6 +61,8 @@
<menupopup id="taskPopup">
<menu id="nightly-menu" label="Nightly Tester Tools" insertafter="devToolsSeparator">
<menupopup onpopupshowing="nightly.menuPopup(event,this);">
+ <menuitem label="&nightly.openabout.label;" oncommand="nightlyApp.openAboutNightly();"/>
+ <menuseparator/>
<menuitem id="nightly-build-copy" label="&nightly.id.copy.label;" oncommand="nightly.copyTemplate('buildid');"/>
<menuitem id="nightly-build-insert" label="&nightly.id.insert.label;" oncommand="nightly.insertTemplate('buildid');"/>
<menuitem id="nightly-list-copy" label="&nightly.extensions.copy.label;" oncommand="nightly.copyExtensions();"/>
1  extension/chrome/locale/en-US/nightly.dtd
View
@@ -1,3 +1,4 @@
+<!ENTITY nightly.openabout.label "Open about:nightly">
<!ENTITY nightly.openprofile.label "Open Profile Folder">
<!ENTITY nightly.id.copy.label "Copy Build ID to Clipboard">
Something went wrong with that request. Please try again.