Include about:nightly in Nightly Tester Tools' menupopup in messengerOverlay.xul. Fixes #56. #76
Conversation
| @@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab) | |||
| return docTitle; | |||
| }, | |||
|
|
|||
| openAboutNightly: function() { | |||
| document.getElementById("tabmail") | |||
| .openTab("contentTab", | |||
There was a problem hiding this comment.
For better readability I would prefer a temporary variable.
|
hm, while thinking a bit more about this request I wonder why we need this. What is included in about:nightly that users have to open it via a menuitem in the main menu? I don't see any functionality in it which would qualify for such a menu item. |
|
whimboo wrote:
Pull request was renamed to Include about:nightly in |
|
Commit updated: temporary variable for "tabmail". |
| @@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab) | |||
| return docTitle; | |||
| }, | |||
|
|
|||
| openAboutNightly: function() { | |||
| var tabmail = document.getElementById("tabmail"); | |||
There was a problem hiding this comment.
nit: please add a blank between function and the opening bracket.
- space between - single line
|
Adressed comments:
Would You mind to let me fold the changes into one commit after |
|
Looks great and I will land it now.
I will do a merge --squash which will combine all of your commits into a single one on master. |
|
Pushed: |
Hi!
This is a trivial fix, "based" on @protz work.
Feel free to review it!