Toolbar button for Notes #515
Conversation
src/background.js
Outdated
|
|
||
| // Handle onClick event for the toolbar button | ||
| browser.browserAction.onClicked.addListener(() => { | ||
| browser.sidebarAction.open(); |
There was a problem hiding this comment.
Don't we have a toggle sidebar Action ?
There was a problem hiding this comment.
@Natim I'm not sure what you mean - are you referring to the Sidebar browser action button that looks like this: https://design.firefox.com/icons/viewer/#sidebar?
If so, that toggles the sidebar, but will open whatever page was last opened in the sidebar (so potentially Bookmarks, History, or Notes open). This PR is supposed to add the toolbar button which opens only opens Notes. Let me know if that's what you meant or not.
|
👍 |
|
@cedricium you can add light and dark theme icons like this: https://github.com/mozilla/speaktome/blob/master/extension/manifest.json#L495 unfortunately they'll need to be PNG. |
|
@cedricium We are back from holiday vacations! woo! did you have time to update the icons to support dark and light themes? Otherwise we are full steam ahead to merge this fro the next release! |
@johngruen the code you linked is using svgs, updated? |
Create new png for src/icons/notes-**.png based on Photons icons styling https://design.firefox.com/icons/viewer/
|
@vladikoff @cedricium Hope this will help, just updated manifest to implement theming on browser_action icons.
|
…open sidebar Keep state in background.js with global variable. Should be refactored with non globale during React integration.
How would we like it to work? Should the icon turn blue when open? @ryanfeeley any idea about that? |
Use a blue icon if Notes add-on is active.
|
Tryed to solve active state on browserAction icon using a blue icon. Not sure if this follow any guideline, need to be discussed/defined.
|
woa awesome!! |
Fixes #535
Initial start at implementing toolbar button to open Notes directly. Currently, if the sidebar is closed and the Notes browser action (toolbar button) is clicked, the sidebar will open with Notes as the active page.
Refs #535
To-Do:
Example:
